PR comments

deansheather · deansheather · commit 85880aca609e · 2024-02-08T14:30:04.000Z
diff --git a/coderd/database/queries/activitybump.sql b/coderd/database/queries/activitybump.sql
@@ -69,7 +69,7 @@ FROM latest l
 WHERE wb.id = l.build_id
 AND l.job_completed_at IS NOT NULL
 -- We only bump if the template has an activity bump duration set.
-AND l.activity_bump IS NOT NULL
+AND l.activity_bump != 0
 AND l.build_transition = 'start'
 -- We only bump if the raw interval is positive and non-zero.
 AND l.ttl_interval > '0 seconds'::interval
diff --git a/coderd/templates.go b/coderd/templates.go
@@ -874,7 +874,7 @@ func (api *API) convertTemplate(
 		autostopRequirementWeeks = 1
 	}
 
-	x := codersdk.Template{
+	return codersdk.Template{
 		ID:                             template.ID,
 		CreatedAt:                      template.CreatedAt,
 		UpdatedAt:                      template.UpdatedAt,
@@ -911,5 +911,4 @@ func (api *API) convertTemplate(
 		Deprecated:           templateAccessControl.IsDeprecated(),
 		DeprecationMessage:   templateAccessControl.Deprecated,
 	}
-	return x
 }

Original file line number	Diff line number	Diff line change
`@@ -874,7 +874,7 @@ func (api *API) convertTemplate(`
`874`	`874`	`autostopRequirementWeeks = 1`
`875`	`875`	`}`
`876`	`876`
`877`		`- x := codersdk.Template{`
	`877`	`+ return codersdk.Template{`
`878`	`878`	`ID: template.ID,`
`879`	`879`	`CreatedAt: template.CreatedAt,`
`880`	`880`	`UpdatedAt: template.UpdatedAt,`
`@@ -911,5 +911,4 @@ func (api *API) convertTemplate(`
`911`	`911`	`Deprecated: templateAccessControl.IsDeprecated(),`
`912`	`912`	`DeprecationMessage: templateAccessControl.Deprecated,`
`913`	`913`	`}`
`914`		`- return x`
`915`	`914`	`}`