Continue beautifying

ammario · ammario · commit 85d473845f7f · 2023-03-23T15:23:18.000Z
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go
@@ -1193,7 +1193,8 @@ func (api *API) watchWorkspaceAgentMetadata(rw http.ResponseWriter, r *http.Requ
 }
 
 func convertWorkspaceAgentMetadata(db []database.WorkspaceAgentMetadatum) []codersdk.WorkspaceAgentMetadata {
-	var result []codersdk.WorkspaceAgentMetadata
+	// An empty array is easier for clients to handle than a null.
+	result := []codersdk.WorkspaceAgentMetadata{}
 	for _, datum := range db {
 		result = append(result, codersdk.WorkspaceAgentMetadata{
 			Result: codersdk.WorkspaceAgentMetadataResult{
diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
@@ -22,15 +22,25 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {
   )
   const staleThreshold = Math.max(
     item.description.interval + item.description.timeout * 2,
-    5,
+    10,
   )
 
   // Stale data is as good as no data. Plus, we want to build confidence in our
   // users that what's shown is real. If times aren't correctly synced this
   // could be buggy. But, how common is that anyways?
   const value =
     secondsSinceLastCollected < staleThreshold ? (
-      <div className={styles.metadataValue}>{item.result.value}</div>
+      <div
+        className={
+          styles.metadataValue +
+          " " +
+          (item.result.error.length === 0
+            ? styles.metadataValueSuccess
+            : styles.metadataValueError)
+        }
+      >
+        {item.result.value}
+      </div>
     ) : (
       <CircularProgress size={12} />
     )
@@ -117,7 +127,13 @@ const useStyles = makeStyles((theme) => ({
   metadataValue: {
     textOverflow: "ellipsis",
     overflow: "hidden",
-    color: theme.palette.success.light,
     whiteSpace: "nowrap",
   },
+
+  metadataValueSuccess: {
+    color: theme.palette.success.light,
+  },
+  metadataValueError: {
+    color: theme.palette.error.main,
+  },
 }))

Original file line number	Diff line number	Diff line change
`@@ -1193,7 +1193,8 @@ func (api API) watchWorkspaceAgentMetadata(rw http.ResponseWriter, r http.Requ`
`1193`	`1193`	`}`
`1194`	`1194`
`1195`	`1195`	`func convertWorkspaceAgentMetadata(db []database.WorkspaceAgentMetadatum) []codersdk.WorkspaceAgentMetadata {`
`1196`		`- var result []codersdk.WorkspaceAgentMetadata`
	`1196`	`+ // An empty array is easier for clients to handle than a null.`
	`1197`	`+ result := []codersdk.WorkspaceAgentMetadata{}`
`1197`	`1198`	`for _, datum := range db {`
`1198`	`1199`	`result = append(result, codersdk.WorkspaceAgentMetadata{`
`1199`	`1200`	`Result: codersdk.WorkspaceAgentMetadataResult{`