Fix test flake introduced by #9264

spikecurtis · spikecurtis · commit 89030405d4e0 · 2023-08-25T09:11:44.000Z
Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;
diff --git a/coderd/templateversions_test.go b/coderd/templateversions_test.go
@@ -308,11 +308,12 @@ func TestPatchCancelTemplateVersion(t *testing.T) {
 		require.Eventually(t, func() bool {
 			var err error
 			version, err = client.TemplateVersion(ctx, version.ID)
+			// job gets marked Failed when there is an Error; in practice we never get to Status = Canceled
+			// because provisioners report an Error when canceled. We check the Error string to ensure we don't mask
+			// other errors in this test.
 			return assert.NoError(t, err) &&
-				// The job will never actually cancel successfully because it will never send a
-				// provision complete response.
-				assert.Empty(t, version.Job.Error) &&
-				version.Job.Status == codersdk.ProvisionerJobCanceling
+				version.Job.Error == "canceled" &&
+				version.Job.Status == codersdk.ProvisionerJobFailed
 		}, testutil.WaitShort, testutil.IntervalFast)
 	})
 }
