Apply suggestions from code review

mafredri · mafredri · commit 89b8297c0647 · 2024-02-20T12:28:03.000+02:00
diff --git a/agent/agent_test.go b/agent/agent_test.go
@@ -300,9 +300,7 @@ func TestAgent_Session_EnvironmentVariables(t *testing.T) {
 		},
 	}
 	banner := codersdk.ServiceBannerConfig{}
-	fs := afero.NewMemMapFs()
 	session := setupSSHSession(t, manifest, banner, nil, func(_ *agenttest.Client, opts *agent.Options) {
-		opts.Filesystem = fs
 		opts.ScriptDataDir = tmpdir
 		opts.EnvironmentVariables["MY_OVERRIDE"] = "true"
 	})
diff --git a/cli/agent.go b/cli/agent.go
@@ -345,7 +345,7 @@ func (r *RootCmd) workspaceAgent() *clibase.Cmd {
 			Flag:        "script-data-dir",
 			Default:     os.TempDir(),
 			Description: "Specify the location for storing script data.",
-			Env:         "CODER_AGENT_SCRIPT_DIR",
+			Env:         "CODER_AGENT_SCRIPT_DATA_DIR",
 			Value:       clibase.StringOf(&scriptDataDir),
 		},
 		{
diff --git a/cli/testdata/coder_agent_--help.golden b/cli/testdata/coder_agent_--help.golden
@@ -33,7 +33,7 @@ OPTIONS:
       --prometheus-address string, $CODER_AGENT_PROMETHEUS_ADDRESS (default: 127.0.0.1:2112)
           The bind address to serve Prometheus metrics.
 
-      --script-data-dir string, $CODER_AGENT_SCRIPT_DIR (default: /tmp)
+      --script-data-dir string, $CODER_AGENT_SCRIPT_DATA_DIR (default: /tmp)
           Specify the location for storing script data.
 
       --ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 72h)

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ func (r RootCmd) workspaceAgent() clibase.Cmd {`
`345`	`345`	`Flag: "script-data-dir",`
`346`	`346`	`Default: os.TempDir(),`
`347`	`347`	`Description: "Specify the location for storing script data.",`
`348`		`- Env: "CODER_AGENT_SCRIPT_DIR",`
	`348`	`+ Env: "CODER_AGENT_SCRIPT_DATA_DIR",`
`349`	`349`	`Value: clibase.StringOf(&scriptDataDir),`
`350`	`350`	`},`
`351`	`351`	`{`