fix(cli): avoid panic when external auth name isn't provided (#12177)

coadler · web-flow · commit 8a9f59a4bbb8 · 2024-02-15T15:17:16.000-06:00
Fixes #10216
diff --git a/cli/externalauth.go b/cli/externalauth.go
@@ -52,6 +52,9 @@ fi
 				Command:     "coder external-auth access-token slack --extra \"authed_user.id\"",
 			},
 		),
+		Middleware: clibase.Chain(
+			clibase.RequireNArgs(1),
+		),
 		Options: clibase.OptionSet{{
 			Name:        "Extra",
 			Flag:        "extra",
diff --git a/cli/externalauth_test.go b/cli/externalauth_test.go
@@ -46,6 +46,19 @@ func TestExternalAuth(t *testing.T) {
 		clitest.Start(t, inv)
 		pty.ExpectMatch("bananas")
 	})
+	t.Run("NoArgs", func(t *testing.T) {
+		t.Parallel()
+		srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			httpapi.Write(context.Background(), w, http.StatusOK, agentsdk.ExternalAuthResponse{
+				AccessToken: "bananas",
+			})
+		}))
+		t.Cleanup(srv.Close)
+		url := srv.URL
+		inv, _ := clitest.New(t, "--agent-url", url, "external-auth", "access-token")
+		watier := clitest.StartWithWaiter(t, inv)
+		watier.RequireContains("wanted 1 args but got 0")
+	})
 	t.Run("SuccessWithExtra", func(t *testing.T) {
 		t.Parallel()
 		srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
