lock

mtojek · mtojek · commit 8aa1d9ad6d0c · 2024-09-06T11:44:26.000+02:00
diff --git a/coderd/database/lock.go b/coderd/database/lock.go
@@ -10,6 +10,7 @@ const (
 	LockIDEnterpriseDeploymentSetup
 	LockIDDBRollup
 	LockIDDBPurge
+	LockIDReportGenerator
 )
 
 // GenLockID generates a unique and consistent lock ID from a given string.
diff --git a/coderd/notifications/reports/generator.go b/coderd/notifications/reports/generator.go
@@ -3,9 +3,10 @@ package reports
 import (
 	"context"
 	"io"
-	"log/slog"
 	"time"
 
+	"cdr.dev/slog"
+
 	"github.com/coder/coder/v2/coderd/database"
 	"github.com/coder/coder/v2/coderd/database/dbauthz"
 	"github.com/coder/coder/v2/coderd/database/dbtime"
@@ -27,6 +28,27 @@ func NewReportGenerator(ctx context.Context, logger slog.Logger, db database.Sto
 	ticker := clk.NewTicker(delay)
 	doTick := func(start time.Time) {
 		defer ticker.Reset(delay)
+		// Start a transaction to grab advisory lock, we don't want to run generator jobs at the same time (multiple replicas).
+		if err := db.InTx(func(tx database.Store) error {
+			// Acquire a lock to ensure that only one instance of the generator is running at a time.
+			ok, err := tx.TryAcquireLock(ctx, database.LockIDReportGenerator)
+			if err != nil {
+				return err
+			}
+			if !ok {
+				logger.Debug(ctx, "unable to acquire lock for generating periodic reports, skipping")
+				return nil
+			}
+
+			// TODO
+
+			logger.Info(ctx, "report generator finished", slog.F("duration", clk.Since(start)))
+
+			return nil
+		}, nil); err != nil {
+			logger.Error(ctx, "failed to generate reports", slog.Error(err))
+			return
+		}
 	}
 
 	go func() {

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ const (`
`10`	`10`	`LockIDEnterpriseDeploymentSetup`
`11`	`11`	`LockIDDBRollup`
`12`	`12`	`LockIDDBPurge`
	`13`	`+ LockIDReportGenerator`
`13`	`14`	`)`
`14`	`15`
`15`	`16`	`// GenLockID generates a unique and consistent lock ID from a given string.`