Add unit test cases

Emyrk · Emyrk · commit 8b3f46d50a37 · 2022-08-24T16:20:12.000-04:00
diff --git a/coderd/httpmw/workspaceparam.go b/coderd/httpmw/workspaceparam.go
@@ -128,10 +128,12 @@ func ExtractWorkspaceAndAgentParam(db database.Store) func(http.Handler) http.Ha
 				return
 			}
 
-			// If we have more than 1 workspace agent, we need to specify which one to use.
 			var agent database.WorkspaceAgent
 			var found bool
-			if len(agents) > 1 {
+			// If we have more than 1 workspace agent, we need to specify which one to use.
+			// If the user specified an agent, we need to make sure that agent
+			// actually exists.
+			if len(workspaceParts) > 1 || len(agents) > 1 {
 				for _, otherAgent := range agents {
 					if otherAgent.Name == workspaceParts[1] {
 						agent = otherAgent
@@ -141,7 +143,7 @@ func ExtractWorkspaceAndAgentParam(db database.Store) func(http.Handler) http.Ha
 				}
 				if !found {
 					httpapi.Write(rw, http.StatusBadRequest, codersdk.Response{
-						Message: fmt.Sprintf("No agent exists with the name %s", workspaceParts[1]),
+						Message: fmt.Sprintf("No agent exists with the name %q", workspaceParts[1]),
 					})
 					return
 				}
diff --git a/coderd/httpmw/workspaceparam_test.go b/coderd/httpmw/workspaceparam_test.go
@@ -175,6 +175,36 @@ func TestWorkspaceAgentByNameParam(t *testing.T) {
 			ExpectedStatusCode: http.StatusBadRequest,
 			ExpectedError:      "More than one agent exists, but no agent specified",
 		},
+		{
+			Name:          "NotExistsOneAgent",
+			WorkspaceName: "dev",
+			Agents: map[string][]string{
+				"resource-a": {
+					"agent-one",
+				},
+			},
+			UrlParam:           "dev.not-exists",
+			ExpectedStatusCode: http.StatusBadRequest,
+			ExpectedError:      "No agent exists with the name",
+		},
+		{
+			Name:          "NotExistsMultipleAgents",
+			WorkspaceName: "dev",
+			Agents: map[string][]string{
+				"resource-a": {
+					"agent-one",
+				},
+				"resource-b": {
+					"agent-two",
+				},
+				"resource-c": {
+					"agent-three",
+				},
+			},
+			UrlParam:           "dev.not-exists",
+			ExpectedStatusCode: http.StatusBadRequest,
+			ExpectedError:      "No agent exists with the name",
+		},
 
 		// OKs
 		{
