fix: ensure r.scriptComplete is not nil

DanielleMaywood · DanielleMaywood · commit 8d325e27c808 · 2024-09-20T10:15:47.000Z
diff --git a/agent/agentscripts/agentscripts.go b/agent/agentscripts/agentscripts.go
@@ -340,20 +340,22 @@ func (r *Runner) run(ctx context.Context, script codersdk.WorkspaceAgentScript,
 			stage = proto.Timing_CRON
 		}
 
-		_, err = r.scriptCompleted(ctx, &proto.WorkspaceAgentScriptCompletedRequest{
-			Timing: &proto.Timing{
-				ScriptId:    script.ID[:],
-				DisplayName: script.DisplayName,
-				Start:       timestamppb.New(start),
-				End:         timestamppb.New(end),
-				ExitCode:    int32(exitCode),
-				Stage:       stage,
-				TimedOut:    errors.Is(err, ErrTimeout),
-			},
-		})
+		if r.scriptCompleted != nil {
+			_, err = r.scriptCompleted(ctx, &proto.WorkspaceAgentScriptCompletedRequest{
+				Timing: &proto.Timing{
+					ScriptId:    script.ID[:],
+					DisplayName: script.DisplayName,
+					Start:       timestamppb.New(start),
+					End:         timestamppb.New(end),
+					ExitCode:    int32(exitCode),
+					Stage:       stage,
+					TimedOut:    errors.Is(err, ErrTimeout),
+				},
+			})
 
-		if err != nil {
-			logger.Error(ctx, fmt.Sprintf("reporting script completed: %s", err.Error()))
+			if err != nil {
+				logger.Error(ctx, fmt.Sprintf("reporting script completed: %s", err.Error()))
+			}
 		}
 	}()
 
