test: verify actually uploaded license with assert (#12934)

Emyrk · web-flow · commit 8da8b89af7aa · 2024-04-10T18:02:08.000-05:00
Prior page.GetByText did not assert it existed
diff --git a/site/e2e/global.setup.ts b/site/e2e/global.setup.ts
@@ -30,6 +30,8 @@ test("setup deployment", async ({ page }) => {
     await page.getByRole("textbox").fill(constants.enterpriseLicense);
     await page.getByText("Upload License").click();
 
-    await page.getByText("You have successfully added a license").isVisible();
+    await expect(
+      page.getByText("You have successfully added a license"),
+    ).toBeVisible();
   }
 });

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,8 @@ test("setup deployment", async ({ page }) => {`
`30`	`30`	`await page.getByRole("textbox").fill(constants.enterpriseLicense);`
`31`	`31`	`await page.getByText("Upload License").click();`
`32`	`32`
`33`		`- await page.getByText("You have successfully added a license").isVisible();`
	`33`	`+ await expect(`
	`34`	`+ page.getByText("You have successfully added a license"),`
	`35`	`+ ).toBeVisible();`
`34`	`36`	`}`
`35`	`37`	`});`