fix more tests

hugodutka · hugodutka · commit 90a9987ac2af · 2024-11-19T17:49:01.000Z
diff --git a/enterprise/coderd/workspaceproxy_test.go b/enterprise/coderd/workspaceproxy_test.go
@@ -7,6 +7,7 @@ import (
 	"net/http/httptest"
 	"net/http/httputil"
 	"net/url"
+	"runtime"
 	"testing"
 	"time"
 
@@ -168,10 +169,16 @@ func TestRegions(t *testing.T) {
 		require.Equal(t, proxy.Url, regions[1].PathAppURL)
 		require.Equal(t, proxy.WildcardHostname, regions[1].WildcardHostname)
 
+		waitTime := testutil.WaitShort / 10
+		// windows needs more time
+		if runtime.GOOS == "windows" {
+			waitTime = testutil.WaitShort / 5
+		}
+
 		// Unfortunately need to wait to assert createdAt/updatedAt
-		<-time.After(testutil.WaitShort / 10)
-		require.WithinDuration(t, approxCreateTime, proxy.CreatedAt, testutil.WaitShort/10)
-		require.WithinDuration(t, approxCreateTime, proxy.UpdatedAt, testutil.WaitShort/10)
+		<-time.After(waitTime)
+		require.WithinDuration(t, approxCreateTime, proxy.CreatedAt, waitTime)
+		require.WithinDuration(t, approxCreateTime, proxy.UpdatedAt, waitTime)
 	})
 
 	t.Run("RequireAuth", func(t *testing.T) {
diff --git a/enterprise/coderd/workspacequota_test.go b/enterprise/coderd/workspacequota_test.go
@@ -6,6 +6,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"runtime"
 	"sync"
 	"testing"
 	"time"
@@ -565,6 +566,10 @@ func TestWorkspaceSerialization(t *testing.T) {
 	})
 
 	t.Run("ActivityBump", func(t *testing.T) {
+		if runtime.GOOS == "windows" {
+			t.Skip("Even though this test is expected to 'likely always fail', it doesn't fail on Windows")
+		}
+
 		t.Log("Expected to fail. As long as quota & deadline are on the same " +
 			" table and affect the same row, this will likely always fail.")
 		//  +---------------------+----------------------------------+
