Skip to content

Commit 9117b7f

Browse files
committed
fix: send existing build parameters for dynamic params
1 parent 80fd236 commit 9117b7f

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

site/src/api/api.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ export const watchWorkspaceAgentLogs = (
234234
/**
235235
* WebSocket compression in Safari (confirmed in 16.5) is broken when
236236
* the server sends large messages. The following error is seen:
237-
* WebSocket connection to 'wss://...' failed: The operation couldnt be completed.
237+
* WebSocket connection to 'wss://...' failed: The operation couldn't be completed.
238238
*/
239239
if (userAgentParser(navigator.userAgent).browser.name === "Safari") {
240240
searchParams.set("no_compression", "");
@@ -2146,11 +2146,17 @@ class ApiMethods {
21462146
await this.axios.delete(`/api/v2/licenses/${licenseId}`);
21472147
};
21482148

2149-
getDynamicParameters = async (templateVersionId: string, ownerId: string) => {
2149+
getDynamicParameters = async (
2150+
templateVersionId: string,
2151+
ownerId: string,
2152+
oldBuildParameters: TypesGen.WorkspaceBuildParameter[],
2153+
) => {
21502154
const request: DynamicParametersRequest = {
21512155
id: 1,
21522156
owner_id: ownerId,
2153-
inputs: {},
2157+
inputs: Object.fromEntries(
2158+
new Map(oldBuildParameters.map((param) => [param.name, param.value])),
2159+
),
21542160
};
21552161

21562162
const dynamicParametersResponse =
@@ -2196,6 +2202,7 @@ class ApiMethods {
21962202
templateParameters = await this.getDynamicParameters(
21972203
templateVersionId,
21982204
workspace.owner_id,
2205+
currentBuildParameters,
21992206
);
22002207
} else {
22012208
templateParameters =
@@ -2246,6 +2253,7 @@ class ApiMethods {
22462253
templateParameters = await this.getDynamicParameters(
22472254
activeVersionId,
22482255
workspace.owner_id,
2256+
oldBuildParameters,
22492257
);
22502258
} else {
22512259
templateParameters =

0 commit comments

Comments
 (0)