PR Feedback

Emyrk · Emyrk · commit 930e7dd37971 · 2023-08-25T10:17:29.000-05:00
diff --git a/coderd/coderdtest/oidctest/idp.go b/coderd/coderdtest/oidctest/idp.go
@@ -376,15 +376,18 @@ func (f *FakeIDP) authenticateBearerTokenRequest(t testing.TB, req *http.Request
 	return token, nil
 }
 
-// authenticateOIDClientRequest enforces the client_id and client_secret are valid.
-func (f *FakeIDP) authenticateOIDClientRequest(t testing.TB, req *http.Request) (url.Values, error) {
+// authenticateOIDCClientRequest enforces the client_id and client_secret are valid.
+func (f *FakeIDP) authenticateOIDCClientRequest(t testing.TB, req *http.Request) (url.Values, error) {
 	t.Helper()
 
 	if f.hookAuthenticateClient != nil {
 		return f.hookAuthenticateClient(t, req)
 	}
 
-	data, _ := io.ReadAll(req.Body)
+	data, err := io.ReadAll(req.Body)
+	if !assert.NoError(t, err, "read token request body") {
+		return nil, xerrors.Errorf("authenticate request, read body: %w", err)
+	}
 	values, err := url.ParseQuery(string(data))
 	if !assert.NoError(t, err, "parse token request values") {
 		return nil, xerrors.New("invalid token request")
@@ -491,7 +494,7 @@ func (f *FakeIDP) httpHandler(t testing.TB) http.Handler {
 	}))
 
 	mux.Handle(tokenPath, http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
-		values, err := f.authenticateOIDClientRequest(t, r)
+		values, err := f.authenticateOIDCClientRequest(t, r)
 		f.logger.Info(r.Context(), "HTTP Call Token",
 			slog.Error(err),
 			slog.F("values", values.Encode()),
diff --git a/enterprise/coderd/userauth_test.go b/enterprise/coderd/userauth_test.go
@@ -57,7 +57,7 @@ func TestUserOIDC(t *testing.T) {
 		// roles from an updated claim.
 		t.Run("NewUserAndRemoveRolesOnRefresh", func(t *testing.T) {
 			// TODO: Implement new feature to update roles/groups on OIDC
-			// refresh tokens.
+			// refresh tokens. https://github.com/coder/coder/issues/9312
 			t.Skip("Refreshing tokens does not update roles :(")
 			t.Parallel()
 
@@ -224,7 +224,7 @@ func TestUserOIDC(t *testing.T) {
 			t.Parallel()
 
 			// TODO: Implement new feature to update roles/groups on OIDC
-			// refresh tokens.
+			// refresh tokens. https://github.com/coder/coder/issues/9312
 			t.Skip("Refreshing tokens does not update groups :(")
 
 			const groupClaim = "custom-groups"
