Remove confirm password from the API

BrunoQuaresma · BrunoQuaresma · commit 96ce7513f258 · 2022-05-05T19:54:50.000Z
diff --git a/coderd/users.go b/coderd/users.go
@@ -368,22 +368,6 @@ func (api *api) putUserPassword(rw http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	// Check if the new password and the confirmation match
-	if params.Password != params.ConfirmPassword {
-		requestErrors := []httpapi.Error{
-			{
-				Field:  "confirm_new_password",
-				Detail: "The value does not match the new password",
-			},
-		}
-		httpapi.Write(rw, http.StatusBadRequest, httpapi.Response{
-			Message: fmt.Sprintf("The new password and the new password confirmation don't match"),
-			Errors:  requestErrors,
-		})
-		return
-	}
-
-	// Hash password and update it in the database
 	hashedPassword, err := userpassword.Hash(params.Password)
 	if err != nil {
 		httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
diff --git a/coderd/users_test.go b/coderd/users_test.go
@@ -290,26 +290,12 @@ func TestUpdateUserProfile(t *testing.T) {
 func TestUpdateUserPassword(t *testing.T) {
 	t.Parallel()
 
-	t.Run("DifferentPasswordConfirmation", func(t *testing.T) {
-		t.Parallel()
-		client := coderdtest.New(t, nil)
-		coderdtest.CreateFirstUser(t, client)
-		err := client.UpdateUserPassword(context.Background(), codersdk.Me, codersdk.UpdateUserPasswordRequest{
-			Password:        "newpassword",
-			ConfirmPassword: "wrongconfirmation",
-		})
-		var apiErr *codersdk.Error
-		require.ErrorAs(t, err, &apiErr)
-		require.Equal(t, http.StatusBadRequest, apiErr.StatusCode())
-	})
-
 	t.Run("Success", func(t *testing.T) {
 		t.Parallel()
 		client := coderdtest.New(t, nil)
 		coderdtest.CreateFirstUser(t, client)
 		err := client.UpdateUserPassword(context.Background(), codersdk.Me, codersdk.UpdateUserPasswordRequest{
-			Password:        "newpassword",
-			ConfirmPassword: "newpassword",
+			Password: "newpassword",
 		})
 		require.NoError(t, err, "update password request should be successful")
 
diff --git a/codersdk/users.go b/codersdk/users.go
@@ -73,8 +73,7 @@ type UpdateUserProfileRequest struct {
 }
 
 type UpdateUserPasswordRequest struct {
-	Password        string `json:"password" validate:"required"`
-	ConfirmPassword string `json:"confirm_new_password" validate:"required"`
+	Password string `json:"password" validate:"required"`
 }
 
 type UpdateRoles struct {
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
@@ -12,7 +12,7 @@ export interface AgentGitSSHKey {
   readonly private_key: string
 }
 
-// From codersdk/users.go:110:6
+// From codersdk/users.go:109:6
 export interface AuthMethods {
   readonly password: boolean
   readonly github: boolean
@@ -44,7 +44,7 @@ export interface CreateFirstUserResponse {
   readonly organization_id: string
 }
 
-// From codersdk/users.go:105:6
+// From codersdk/users.go:104:6
 export interface CreateOrganizationRequest {
   readonly name: string
 }
@@ -101,7 +101,7 @@ export interface CreateWorkspaceRequest {
   readonly parameter_values: CreateParameterRequest[]
 }
 
-// From codersdk/users.go:101:6
+// From codersdk/users.go:100:6
 export interface GenerateAPIKeyResponse {
   readonly key: string
 }
@@ -119,13 +119,13 @@ export interface GoogleInstanceIdentityToken {
   readonly json_web_token: string
 }
 
-// From codersdk/users.go:90:6
+// From codersdk/users.go:89:6
 export interface LoginWithPasswordRequest {
   readonly email: string
   readonly password: string
 }
 
-// From codersdk/users.go:96:6
+// From codersdk/users.go:95:6
 export interface LoginWithPasswordResponse {
   readonly session_token: string
 }
@@ -255,15 +255,14 @@ export interface UpdateActiveTemplateVersion {
   readonly id: string
 }
 
-// From codersdk/users.go:80:6
+// From codersdk/users.go:79:6
 export interface UpdateRoles {
   readonly roles: string[]
 }
 
 // From codersdk/users.go:75:6
 export interface UpdateUserPasswordRequest {
   readonly password: string
-  readonly confirm_new_password: string
 }
 
 // From codersdk/users.go:70:6
@@ -297,7 +296,7 @@ export interface User {
   readonly organization_ids: string[]
 }
 
-// From codersdk/users.go:84:6
+// From codersdk/users.go:83:6
 export interface UserRoles {
   readonly roles: string[]
   readonly organization_roles: Record<string, string[]>

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,7 @@ type UpdateUserProfileRequest struct {`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`type UpdateUserPasswordRequest struct {`
`76`		- Password string `json:"password" validate:"required"`
`77`		- ConfirmPassword string `json:"confirm_new_password" validate:"required"`
	`76`	+ Password string `json:"password" validate:"required"`
`78`	`77`	`}`
`79`	`78`
`80`	`79`	`type UpdateRoles struct {`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ export interface AgentGitSSHKey {`
`12`	`12`	`readonly private_key: string`
`13`	`13`	`}`
`14`	`14`
`15`		`-// From codersdk/users.go:110:6`
	`15`	`+// From codersdk/users.go:109:6`
`16`	`16`	`export interface AuthMethods {`
`17`	`17`	`readonly password: boolean`
`18`	`18`	`readonly github: boolean`
`@@ -44,7 +44,7 @@ export interface CreateFirstUserResponse {`
`44`	`44`	`readonly organization_id: string`
`45`	`45`	`}`
`46`	`46`
`47`		`-// From codersdk/users.go:105:6`
	`47`	`+// From codersdk/users.go:104:6`
`48`	`48`	`export interface CreateOrganizationRequest {`
`49`	`49`	`readonly name: string`
`50`	`50`	`}`
`@@ -101,7 +101,7 @@ export interface CreateWorkspaceRequest {`
`101`	`101`	`readonly parameter_values: CreateParameterRequest[]`
`102`	`102`	`}`
`103`	`103`
`104`		`-// From codersdk/users.go:101:6`
	`104`	`+// From codersdk/users.go:100:6`
`105`	`105`	`export interface GenerateAPIKeyResponse {`
`106`	`106`	`readonly key: string`
`107`	`107`	`}`
`@@ -119,13 +119,13 @@ export interface GoogleInstanceIdentityToken {`
`119`	`119`	`readonly json_web_token: string`
`120`	`120`	`}`
`121`	`121`
`122`		`-// From codersdk/users.go:90:6`
	`122`	`+// From codersdk/users.go:89:6`
`123`	`123`	`export interface LoginWithPasswordRequest {`
`124`	`124`	`readonly email: string`
`125`	`125`	`readonly password: string`
`126`	`126`	`}`
`127`	`127`
`128`		`-// From codersdk/users.go:96:6`
	`128`	`+// From codersdk/users.go:95:6`
`129`	`129`	`export interface LoginWithPasswordResponse {`
`130`	`130`	`readonly session_token: string`
`131`	`131`	`}`
`@@ -255,15 +255,14 @@ export interface UpdateActiveTemplateVersion {`
`255`	`255`	`readonly id: string`
`256`	`256`	`}`
`257`	`257`
`258`		`-// From codersdk/users.go:80:6`
	`258`	`+// From codersdk/users.go:79:6`
`259`	`259`	`export interface UpdateRoles {`
`260`	`260`	`readonly roles: string[]`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`// From codersdk/users.go:75:6`
`264`	`264`	`export interface UpdateUserPasswordRequest {`
`265`	`265`	`readonly password: string`
`266`		`- readonly confirm_new_password: string`
`267`	`266`	`}`
`268`	`267`
`269`	`268`	`// From codersdk/users.go:70:6`
`@@ -297,7 +296,7 @@ export interface User {`
`297`	`296`	`readonly organization_ids: string[]`
`298`	`297`	`}`
`299`	`298`
`300`		`-// From codersdk/users.go:84:6`
	`299`	`+// From codersdk/users.go:83:6`
`301`	`300`	`export interface UserRoles {`
`302`	`301`	`readonly roles: string[]`
`303`	`302`	`readonly organization_roles: Record<string, string[]>`