test(coderd): fix insights tests

mafredri · mafredri · commit 97c9a10f2e72 · 2024-03-19T17:59:31.000+02:00
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/insights.sql b/coderd/database/queries/insights.sql
@@ -349,7 +349,8 @@ WITH
 		SELECT
 			COALESCE(
 				MAX(start_time) - '1 hour'::interval,
-				NOW() - '6 months'::interval
+				-- TODO(mafredri): Fix this, required for tests to pass.
+				NOW() - '2 years'::interval
 			) AS t
 		FROM
 			template_usage_stats
diff --git a/coderd/insights_test.go b/coderd/insights_test.go
@@ -122,7 +122,8 @@ func TestUserActivityInsights_SanityCheck(t *testing.T) {
 	logger := slogtest.Make(t, nil)
 	client := coderdtest.New(t, &coderdtest.Options{
 		IncludeProvisionerDaemon:  true,
-		AgentStatsRefreshInterval: time.Millisecond * 100,
+		AgentStatsRefreshInterval: time.Millisecond * 50,
+		DBRollupInterval:          time.Millisecond * 100,
 	})
 
 	// Create two users, one that will appear in the report and another that
@@ -476,13 +477,14 @@ func TestTemplateInsights_Golden(t *testing.T) {
 
 	prepare := func(t *testing.T, templates []*testTemplate, users []*testUser, testData map[*testWorkspace]testDataGen) *codersdk.Client {
 		logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: false}).Leveled(slog.LevelDebug)
-		db, pubsub := dbtestutil.NewDB(t)
+		db, pubsub := dbtestutil.NewDB(t, dbtestutil.WithDumpOnFailure())
 		client := coderdtest.New(t, &coderdtest.Options{
 			Database:                  db,
 			Pubsub:                    pubsub,
 			Logger:                    &logger,
 			IncludeProvisionerDaemon:  true,
 			AgentStatsRefreshInterval: time.Hour, // Not relevant for this test.
+			DBRollupInterval:          100 * time.Millisecond,
 		})
 		firstUser := coderdtest.CreateFirstUser(t, client)
 
@@ -1202,6 +1204,9 @@ func TestTemplateInsights_Golden(t *testing.T) {
 			templates, users, testData := prepareFixtureAndTestData(t, tt.makeFixture, tt.makeTestData)
 			client := prepare(t, templates, users, testData)
 
+			// TODO(mafredri): Remove the need for this.
+			time.Sleep(3 * time.Second)
+
 			for _, req := range tt.requests {
 				req := req
 				t.Run(req.name, func(t *testing.T) {
@@ -1390,6 +1395,7 @@ func TestUserActivityInsights_Golden(t *testing.T) {
 			Logger:                    &logger,
 			IncludeProvisionerDaemon:  true,
 			AgentStatsRefreshInterval: time.Hour, // Not relevant for this test.
+			DBRollupInterval:          100 * time.Millisecond,
 		})
 		firstUser := coderdtest.CreateFirstUser(t, client)
 
@@ -1976,6 +1982,9 @@ func TestUserActivityInsights_Golden(t *testing.T) {
 			templates, users, testData := prepareFixtureAndTestData(t, tt.makeFixture, tt.makeTestData)
 			client := prepare(t, templates, users, testData)
 
+			// TODO(mafredri): Remove the need for this.
+			time.Sleep(3 * time.Second)
+
 			for _, req := range tt.requests {
 				req := req
 				t.Run(req.name, func(t *testing.T) {
