fix: autostart: add more test cases

johnstcn · johnstcn · commit 9854f9b6ddf4 · 2022-04-06T20:05:21.000Z
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -13,6 +13,7 @@ import (
 	"github.com/moby/moby/pkg/namesgenerator"
 	"golang.org/x/xerrors"
 
+	"github.com/coder/coder/coderd/autostart/schedule"
 	"github.com/coder/coder/coderd/database"
 	"github.com/coder/coder/coderd/httpapi"
 	"github.com/coder/coder/coderd/httpmw"
@@ -291,18 +292,28 @@ func (api *api) workspaceBuildByName(rw http.ResponseWriter, r *http.Request) {
 }
 
 func (api *api) putWorkspaceAutostart(rw http.ResponseWriter, r *http.Request) {
-	var spec codersdk.UpdateWorkspaceAutostartRequest
-	if !httpapi.Read(rw, r, &spec) {
+	var req codersdk.UpdateWorkspaceAutostartRequest
+	if !httpapi.Read(rw, r, &req) {
 		return
 	}
 
+	var dbSched sql.NullString
+	if req.Schedule != "" {
+		validSched, err := schedule.Weekly(req.Schedule)
+		if err != nil {
+			httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
+				Message: fmt.Sprintf("invalid autostart schedule: %s", err),
+			})
+			return
+		}
+		dbSched.String = validSched.String()
+		dbSched.Valid = true
+	}
+
 	workspace := httpmw.WorkspaceParam(r)
 	err := api.Database.UpdateWorkspaceAutostart(r.Context(), database.UpdateWorkspaceAutostartParams{
-		ID: workspace.ID,
-		AutostartSchedule: sql.NullString{
-			String: spec.Schedule,
-			Valid:  true,
-		},
+		ID:                workspace.ID,
+		AutostartSchedule: dbSched,
 	})
 	if err != nil {
 		httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -186,8 +186,6 @@ func TestWorkspaceBuildByName(t *testing.T) {
 }
 
 func TestWorkspaceUpdateAutostart(t *testing.T) {
-	// fri -> monday
-	// TODO(cian): mon -> tue
 	// TODO(cian): CST -> CDT
 	// TODO(cian): CDT -> CST
 
@@ -200,13 +198,35 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {
 		at            time.Time
 		expectedNext  time.Time
 	}{
+		{
+			name:          "disable autostart",
+			schedule:      "",
+			expectedError: "",
+		},
 		{
 			name:          "friday to monday",
 			schedule:      "CRON_TZ=Europe/Dublin 30 9 1-5",
 			expectedError: "",
 			at:            time.Date(2022, 5, 6, 9, 31, 0, 0, dublinLoc),
 			expectedNext:  time.Date(2022, 5, 9, 9, 30, 0, 0, dublinLoc),
 		},
+		{
+			name:          "monday to tuesday",
+			schedule:      "CRON_TZ=Europe/Dublin 30 9 1-5",
+			expectedError: "",
+			at:            time.Date(2022, 5, 9, 9, 31, 0, 0, dublinLoc),
+			expectedNext:  time.Date(2022, 5, 10, 9, 30, 0, 0, dublinLoc),
+		},
+		{
+			name:          "invalid location",
+			schedule:      "CRON_TZ=Imaginary/Place 30 9 1-5",
+			expectedError: "status code 500: invalid autostart schedule: parse schedule: provided bad location Imaginary/Place: unknown time zone Imaginary/Place",
+		},
+		{
+			name:          "invalid schedule",
+			schedule:      "asdf asdf asdf ",
+			expectedError: `status code 500: invalid autostart schedule: parse schedule: failed to parse int from asdf: strconv.Atoi: parsing "asdf": invalid syntax`,
+		},
 	}
 
 	for _, testCase := range testCases {
@@ -229,13 +249,22 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {
 			err := client.UpdateWorkspaceAutostart(ctx, workspace.ID, codersdk.UpdateWorkspaceAutostartRequest{
 				Schedule: testCase.schedule,
 			})
+
+			if testCase.expectedError != "" {
+				require.EqualError(t, err, testCase.expectedError, "unexpected error when setting workspace autostart schedule")
+				return
+			}
+
 			require.NoError(t, err, "expected no error setting workspace autostart schedule")
 
 			updated, err := client.Workspace(ctx, workspace.ID)
 			require.NoError(t, err, "fetch updated workspace")
 
 			require.Equal(t, testCase.schedule, updated.AutostartSchedule, "expected autostart schedule to equal requested")
 
+			if testCase.schedule == "" {
+				return
+			}
 			sched, err := schedule.Weekly(updated.AutostartSchedule)
 			require.NoError(t, err, "parse returned schedule")
 
