chore: ui error handling should be specific to general

Emyrk · Emyrk · commit 98bdb6b4ae70 · 2024-08-19T08:42:35.000-05:00
Specific errors should be checked before defaulting to a general
error handling
diff --git a/site/src/api/errors.ts b/site/src/api/errors.ts
@@ -115,10 +115,6 @@ export const getErrorDetail = (error: unknown): string | undefined => {
 		return error.detail;
 	}
 
-	if (error instanceof Error) {
-		return "Please check the developer console for more details.";
-	}
-
 	if (isApiError(error)) {
 		return error.response.data.detail;
 	}
@@ -127,6 +123,10 @@ export const getErrorDetail = (error: unknown): string | undefined => {
 		return error.detail;
 	}
 
+	if (error instanceof Error) {
+		return "Please check the developer console for more details.";
+	}
+
 	return undefined;
 };
 

Original file line number	Diff line number	Diff line change
`@@ -115,10 +115,6 @@ export const getErrorDetail = (error: unknown): string \| undefined => {`
`115`	`115`	`return error.detail;`
`116`	`116`	`}`
`117`	`117`
`118`		`- if (error instanceof Error) {`
`119`		`- return "Please check the developer console for more details.";`
`120`		`- }`
`121`		`-`
`122`	`118`	`if (isApiError(error)) {`
`123`	`119`	`return error.response.data.detail;`
`124`	`120`	`}`
`@@ -127,6 +123,10 @@ export const getErrorDetail = (error: unknown): string \| undefined => {`
`127`	`123`	`return error.detail;`
`128`	`124`	`}`
`129`	`125`
	`126`	`+ if (error instanceof Error) {`
	`127`	`+ return "Please check the developer console for more details.";`
	`128`	`+ }`
	`129`	`+`
`130`	`130`	`return undefined;`
`131`	`131`	`};`
`132`	`132`