chore: bypass the per-day notification dedupe

ssncferreira · ssncferreira · commit 9a396935b80d · 2025-09-10T16:59:42.000Z
diff --git a/coderd/notifications.go b/coderd/notifications.go
@@ -396,7 +396,7 @@ func (api *API) postCustomNotification(rw http.ResponseWriter, r *http.Request)
 		return
 	}
 
-	if _, err := api.NotificationsEnqueuer.Enqueue(
+	if _, err := api.NotificationsEnqueuer.EnqueueWithData(
 		//nolint:gocritic // We need to be notifier to send the notification.
 		dbauthz.AsNotifier(ctx),
 		user.ID,
@@ -405,6 +405,15 @@ func (api *API) postCustomNotification(rw http.ResponseWriter, r *http.Request)
 			"custom_title":   req.Content.Title,
 			"custom_message": req.Content.Message,
 		},
+		map[string]any{
+			// Current dedupe is done via an hash of (template, user, method, payload, targets, day).
+			// We intentionally include a timestamp to bypass the per-day dedupe so the caller can
+			// resend identical content to themselves multiple times in one day.
+			// TODO(ssncferreira): When we support sending custom notifications to multiple users/roles,
+			//   enforce proper deduplication across recipients to reduce noise and prevent spam.
+			//   See https://github.com/coder/coder/issues/19768
+			"dedupe_bypass_ts": api.Clock.Now().UTC(),
+		},
 		user.ID.String(),
 	); err != nil {
 		api.Logger.Error(ctx, "send custom notification", slog.Error(err))
diff --git a/codersdk/notifications.go b/codersdk/notifications.go
@@ -290,6 +290,7 @@ type CustomNotificationContent struct {
 type CustomNotificationRequest struct {
 	Content *CustomNotificationContent `json:"content"`
 	// TODO(ssncferreira): Add target (user_ids, roles) to support multi-user and role-based delivery.
+	//   See: https://github.com/coder/coder/issues/19768
 }
 
 func (c CustomNotificationRequest) Validate() error {
diff --git a/docs/admin/monitoring/notifications/index.md b/docs/admin/monitoring/notifications/index.md
@@ -271,6 +271,10 @@ At this time, custom notifications can only be sent to the user making the reque
 
 To send a custom notification, execute [`coder notifications custom <title> <message>`](../../../reference/cli/notifications_custom.md).
 
+<!-- TODO(ssncferreira): Update when sending custom notifications to multiple users/roles is supported.
+	 Explain deduplication behaviour for multiple users/roles.
+	 See: https://github.com/coder/coder/issues/19768
+-->
 **Note:** The recipient is always the requesting user as targeting other users or groups isn’t supported yet.
 
 ### Examples

Original file line number	Diff line number	Diff line change
`@@ -290,6 +290,7 @@ type CustomNotificationContent struct {`
`290`	`290`	`type CustomNotificationRequest struct {`
`291`	`291`	Content *CustomNotificationContent `json:"content"`
`292`	`292`	`// TODO(ssncferreira): Add target (user_ids, roles) to support multi-user and role-based delivery.`
	`293`	`+ // See: https://github.com/coder/coder/issues/19768`
`293`	`294`	`}`
`294`	`295`
`295`	`296`	`func (c CustomNotificationRequest) Validate() error {`