permissions comment

Emyrk · Emyrk · commit 9aff25da6b2c · 2024-06-17T14:24:41.000-05:00
diff --git a/cli/organizationmembers.go b/cli/organizationmembers.go
@@ -46,6 +46,7 @@ func (r *RootCmd) addOrganizationMember() *serpent.Command {
 				return err
 			}
 			user := inv.Args[0]
+
 			_, err = client.PostOrganizationMember(ctx, organization.ID, user)
 			if err != nil {
 				return xerrors.Errorf("could not add member to organization: %w", err)
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -847,6 +847,10 @@ func New(options *Options) *API {
 					r.Route("/{user}", func(r chi.Router) {
 						r.Group(func(r chi.Router) {
 							r.Use(
+								// Adding a member requires "read" permission
+								// on the site user. So limited to owners and user-admins.
+								// TODO: Allow org-admins to add users via some new permission? Or give them
+								// 	read on site users.
 								httpmw.ExtractUserParam(options.Database),
 							)
 							r.Post("/", api.postOrganizationMember)

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ func (r RootCmd) addOrganizationMember() serpent.Command {`
`46`	`46`	`return err`
`47`	`47`	`}`
`48`	`48`	`user := inv.Args[0]`
	`49`	`+`
`49`	`50`	`_, err = client.PostOrganizationMember(ctx, organization.ID, user)`
`50`	`51`	`if err != nil {`
`51`	`52`	`return xerrors.Errorf("could not add member to organization: %w", err)`