fixup! feat: add prometheus metric for tracking user statuses

coadler · coadler · commit 9b0d26dbaae8 · 2024-10-30T05:10:37.000Z
diff --git a/coderd/prometheusmetrics/prometheusmetrics.go b/coderd/prometheusmetrics/prometheusmetrics.go
@@ -106,9 +106,11 @@ func Users(ctx context.Context, logger slog.Logger, registerer prometheus.Regist
 			}
 
 			gauge.Reset()
+			//nolint:gocritic // This is a system service that needs full access
+			//to the users table.
 			users, err := db.GetUsers(dbauthz.AsSystemRestricted(ctx), database.GetUsersParams{})
 			if err != nil {
-				logger.Error(ctx, "get users", slog.Error(err))
+				logger.Error(ctx, "get all users for prometheus metrics", slog.Error(err))
 				continue
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -106,9 +106,11 @@ func Users(ctx context.Context, logger slog.Logger, registerer prometheus.Regist`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`gauge.Reset()`
	`109`	`+ //nolint:gocritic // This is a system service that needs full access`
	`110`	`+ //to the users table.`
`109`	`111`	`users, err := db.GetUsers(dbauthz.AsSystemRestricted(ctx), database.GetUsersParams{})`
`110`	`112`	`if err != nil {`
`111`		`- logger.Error(ctx, "get users", slog.Error(err))`
	`113`	`+ logger.Error(ctx, "get all users for prometheus metrics", slog.Error(err))`
`112`	`114`	`continue`
`113`	`115`	`}`
`114`	`116`