fix: Use immutable names for volumes in example templates

mafredri · mafredri · commit 9b49e37e8204 · 2022-08-24T16:20:16.000+03:00
This contributes towards #3000, #3386 Related #3409
diff --git a/docs/templates.md b/docs/templates.md
@@ -187,7 +187,7 @@ data "coder_workspace" "me" {
 resource "docker_volume" "home_volume" {
   # persistent resource (remains a workspace is stopped)
   count = 1
-  name  = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"
+  name  = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
diff --git a/dogfood/main.tf b/dogfood/main.tf
@@ -46,14 +46,14 @@ resource "coder_app" "code-server" {
 
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-home"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "coder_metadata" "home_info" {
   resource_id = docker_volume.home_volume.id
   item {
-    key = "🤫🤫🤫<br/><br/>"
-    value = "❤️❤️❤️"
+    key       = "🤫🤫🤫<br/><br/>"
+    value     = "❤️❤️❤️"
     sensitive = true
   }
 }
@@ -93,14 +93,14 @@ resource "docker_container" "workspace" {
 }
 
 resource "coder_metadata" "container_info" {
-  count = data.coder_workspace.me.start_count
+  count       = data.coder_workspace.me.start_count
   resource_id = docker_container.workspace[0].id
   item {
-    key = "memory"
+    key   = "memory"
     value = docker_container.workspace[0].memory
   }
   item {
-    key = "runtime"
+    key   = "runtime"
     value = docker_container.workspace[0].runtime
   }
 }
diff --git a/examples/templates/do-linux/main.tf b/examples/templates/do-linux/main.tf
@@ -100,7 +100,7 @@ resource "coder_agent" "main" {
 
 resource "digitalocean_volume" "home_volume" {
   region                   = var.region
-  name                     = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-home"
+  name                     = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
   size                     = var.home_volume_size
   initial_filesystem_type  = "ext4"
   initial_filesystem_label = "coder-home"
diff --git a/examples/templates/docker-code-server/main.tf b/examples/templates/docker-code-server/main.tf
@@ -44,7 +44,7 @@ resource "coder_app" "code-server" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
diff --git a/examples/templates/docker-image-builds/main.tf b/examples/templates/docker-image-builds/main.tf
@@ -45,7 +45,7 @@ variable "docker_image" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_image" "coder_image" {
diff --git a/examples/templates/docker-with-dotfiles/main.tf b/examples/templates/docker-with-dotfiles/main.tf
@@ -43,7 +43,7 @@ resource "coder_agent" "main" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
diff --git a/examples/templates/docker/main.tf b/examples/templates/docker/main.tf
@@ -62,7 +62,7 @@ variable "docker_image" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-home"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
@@ -75,7 +75,8 @@ resource "docker_container" "workspace" {
   dns      = ["1.1.1.1"]
   # Use the docker gateway if the access URL is 127.0.0.1
   command = [
-    "sh", "-c", replace(coder_agent.main.init_script, "localhost", "host.docker.internal")]
+    "sh", "-c", replace(coder_agent.main.init_script, "localhost", "host.docker.internal")
+  ]
   env = ["CODER_AGENT_TOKEN=${coder_agent.main.token}"]
   host {
     host = "host.docker.internal"
diff --git a/examples/templates/gcp-linux/main.tf b/examples/templates/gcp-linux/main.tf
@@ -36,7 +36,7 @@ data "coder_workspace" "me" {
 }
 
 resource "google_compute_disk" "root" {
-  name  = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"
+  name  = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"
   type  = "pd-ssd"
   zone  = var.zone
   image = "debian-cloud/debian-10"
diff --git a/examples/templates/gcp-windows/main.tf b/examples/templates/gcp-windows/main.tf
@@ -36,7 +36,7 @@ data "google_compute_default_service_account" "default" {
 }
 
 resource "google_compute_disk" "root" {
-  name  = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"
+  name  = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"
   type  = "pd-ssd"
   zone  = var.zone
   image = "projects/windows-cloud/global/images/windows-server-2022-dc-core-v20220215"

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ data "coder_workspace" "me" {`
`187`	`187`	`resource "docker_volume" "home_volume" {`
`188`	`188`	`# persistent resource (remains a workspace is stopped)`
`189`	`189`	`count = 1`
`190`		`- name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"`
	`190`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -46,14 +46,14 @@ resource "coder_app" "code-server" {`
`46`	`46`
`47`	`47`
`48`	`48`	`resource "docker_volume" "home_volume" {`
`49`		`- name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-home"`
	`49`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`resource "coder_metadata" "home_info" {`
`53`	`53`	`resource_id = docker_volume.home_volume.id`
`54`	`54`	`item {`
`55`		`- key = "🤫🤫🤫<br/><br/>"`
`56`		`- value = "❤️❤️❤️"`
	`55`	`+ key = "🤫🤫🤫<br/><br/>"`
	`56`	`+ value = "❤️❤️❤️"`
`57`	`57`	`sensitive = true`
`58`	`58`	`}`
`59`	`59`	`}`
`@@ -93,14 +93,14 @@ resource "docker_container" "workspace" {`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`resource "coder_metadata" "container_info" {`
`96`		`- count = data.coder_workspace.me.start_count`
	`96`	`+ count = data.coder_workspace.me.start_count`
`97`	`97`	`resource_id = docker_container.workspace[0].id`
`98`	`98`	`item {`
`99`		`- key = "memory"`
	`99`	`+ key = "memory"`
`100`	`100`	`value = docker_container.workspace[0].memory`
`101`	`101`	`}`
`102`	`102`	`item {`
`103`		`- key = "runtime"`
	`103`	`+ key = "runtime"`
`104`	`104`	`value = docker_container.workspace[0].runtime`
`105`	`105`	`}`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ resource "coder_app" "code-server" {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`resource "docker_volume" "home_volume" {`
`47`		`- name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"`
	`47`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ variable "docker_image" {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`resource "docker_volume" "home_volume" {`
`48`		`- name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"`
	`48`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`resource "docker_image" "coder_image" {`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ resource "coder_agent" "main" {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`resource "docker_volume" "home_volume" {`
`46`		`- name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"`
	`46`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ data "coder_workspace" "me" {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`resource "google_compute_disk" "root" {`
`39`		`- name = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"`
	`39`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"`
`40`	`40`	`type = "pd-ssd"`
`41`	`41`	`zone = var.zone`
`42`	`42`	`image = "debian-cloud/debian-10"`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ data "google_compute_default_service_account" "default" {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`resource "google_compute_disk" "root" {`
`39`		`- name = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"`
	`39`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"`
`40`	`40`	`type = "pd-ssd"`
`41`	`41`	`zone = var.zone`
`42`	`42`	`image = "projects/windows-cloud/global/images/windows-server-2022-dc-core-v20220215"`