fix: potential deadlock in coordinator (#4598)

sreya · web-flow · commit 9b4ab82044c6 · 2022-10-17T20:46:19.000Z
diff --git a/tailnet/coordinator.go b/tailnet/coordinator.go
@@ -313,6 +313,7 @@ func (c *coordinator) handleNextAgentMessage(id uuid.UUID, decoder *json.Decoder
 	}
 	data, err := json.Marshal([]*Node{&node})
 	if err != nil {
+		c.mutex.Unlock()
 		return xerrors.Errorf("marshal nodes: %w", err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -313,6 +313,7 @@ func (c coordinator) handleNextAgentMessage(id uuid.UUID, decoder json.Decoder`
`313`	`313`	`}`
`314`	`314`	`data, err := json.Marshal([]*Node{&node})`
`315`	`315`	`if err != nil {`
	`316`	`+ c.mutex.Unlock()`
`316`	`317`	`return xerrors.Errorf("marshal nodes: %w", err)`
`317`	`318`	`}`
`318`	`319`