More fixes

mtojek · mtojek · commit 9b7c40e0ad1f · 2023-07-27T13:03:15.000+02:00
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -575,18 +575,20 @@ func createAnotherUserRetry(t *testing.T, client *codersdk.Client, organizationI
 		sessionToken = token.Key
 	}
 
+	if user.Status == codersdk.UserStatusDormant {
+		// Use admin client so that user's LastSeenAt is not updated.
+		// In general we need to refresh the user status, which should
+		// transition from "dormant" to "active".
+		user, err = client.User(context.Background(), user.Username)
+		require.NoError(t, err)
+	}
+
 	other := codersdk.New(client.URL)
 	other.SetSessionToken(sessionToken)
 	t.Cleanup(func() {
 		other.HTTPClient.CloseIdleConnections()
 	})
 
-	if !req.DisableLogin && user.Status == codersdk.UserStatusDormant {
-		// Refresh user account which should be active now.
-		user, err = other.User(context.Background(), user.Username)
-		require.NoError(t, err)
-	}
-
 	if len(roles) > 0 {
 		// Find the roles for the org vs the site wide roles
 		orgRoles := make(map[string][]string)
