Fix lint and tests

ammario · ammario · commit 9bbc25188f84 · 2024-01-21T14:50:58.000-06:00
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -3758,7 +3758,7 @@ func (q *FakeQuerier) GetUserLinksByUserID(_ context.Context, userID uuid.UUID)
 	return uls, nil
 }
 
-func (q *FakeQuerier) GetUserWorkspaceBuildParameters(ctx context.Context, ownerID uuid.UUID) ([]database.GetUserWorkspaceBuildParametersRow, error) {
+func (q *FakeQuerier) GetUserWorkspaceBuildParameters(_ context.Context, ownerID uuid.UUID) ([]database.GetUserWorkspaceBuildParametersRow, error) {
 	q.mutex.RLock()
 	defer q.mutex.RUnlock()
 
diff --git a/site/src/components/RichParameterInput/RichParameterInput.tsx b/site/src/components/RichParameterInput/RichParameterInput.tsx
@@ -161,7 +161,7 @@ export const RichParameterInput: FC<RichParameterInputProps> = ({
         <RichParameterField {...fieldProps} size={size} parameter={parameter} />
         {defaultReason && (
           <div css={{ marginTop: 4, fontSize: 12 }}>
-            🪄 Autofilled {defaultReason}
+            🪄 Autofilled: {defaultReason}
           </div>
         )}
       </div>
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx
@@ -241,7 +241,9 @@ describe("CreateWorkspacePage", () => {
         "me",
         expect.objectContaining({
           template_id: MockTemplate.id,
-          rich_parameter_values: [{ name: param, value: paramValue }],
+          rich_parameter_values: [
+            { name: param, value: paramValue, reason: <>supplied by URL</> },
+          ],
         }),
       );
     });
@@ -266,7 +268,9 @@ describe("CreateWorkspacePage", () => {
         "me",
         expect.objectContaining({
           template_version_id: MockTemplate.active_version_id,
-          rich_parameter_values: [{ name: param, value: paramValue }],
+          rich_parameter_values: [
+            { name: param, value: paramValue, reason: <>supplied by URL</> },
+          ],
         }),
       );
     });
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
@@ -2,7 +2,6 @@ import {
   TemplateVersionParameter,
   UserParameter,
   Workspace,
-  WorkspaceBuildParameter,
 } from "api/typesGenerated";
 import { useMe } from "hooks/useMe";
 import { useOrganizationId } from "hooks/useOrganizationId";
@@ -243,7 +242,11 @@ const getDefaultBuildParameters = (
     buildValues.push({
       name: param.name,
       value: param.value,
-      reason: <>recently used value</>,
+      reason: (
+        <>
+          recently used <code>{param.name}</code> value.
+        </>
+      ),
     });
   });
   return buildValues;
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx
@@ -86,6 +86,13 @@ export const Parameters: Story = {
         ephemeral: false,
       },
     ],
+    defaultBuildParameters: [
+      {
+        name: "first_parameter",
+        value: "It works!",
+        reason: <>recently used.</>,
+      },
+    ],
   },
 };
 

Original file line number	Diff line number	Diff line change
`@@ -3758,7 +3758,7 @@ func (q *FakeQuerier) GetUserLinksByUserID(_ context.Context, userID uuid.UUID)`
`3758`	`3758`	`return uls, nil`
`3759`	`3759`	`}`
`3760`	`3760`
`3761`		`-func (q *FakeQuerier) GetUserWorkspaceBuildParameters(ctx context.Context, ownerID uuid.UUID) ([]database.GetUserWorkspaceBuildParametersRow, error) {`
	`3761`	`+func (q *FakeQuerier) GetUserWorkspaceBuildParameters(_ context.Context, ownerID uuid.UUID) ([]database.GetUserWorkspaceBuildParametersRow, error) {`
`3762`	`3762`	`q.mutex.RLock()`
`3763`	`3763`	`defer q.mutex.RUnlock()`
`3764`	`3764`