fix tests

SasSwart · SasSwart · commit 9d0b08b31391 · 2025-02-07T12:29:33.000Z
diff --git a/provisioner/terraform/provision.go b/provisioner/terraform/provision.go
@@ -269,8 +269,7 @@ func provisionEnv(
 		env = append(env, provider.ParameterEnvironmentVariable(param.Name)+"="+param.Value)
 	}
 	for _, extAuth := range externalAuth {
-		// TODO (sasswart): what's going on with provider.GitAuthAccessTokenEnvironmentVariable here?
-		// do we still need it? I've removed it for now.
+		env = append(env, provider.GitAuthAccessTokenEnvironmentVariable(extAuth.Id)+"="+extAuth.AccessToken)
 		env = append(env, provider.ExternalAuthAccessTokenEnvironmentVariable(extAuth.Id)+"="+extAuth.AccessToken)
 	}
 
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -161,7 +161,9 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
 	}, [presets]);
 
 	const [selectedPresetIndex, setSelectedPresetIndex] = useState(0);
-	const [presetParameterNames, setPresetParameterNames] = useState<string[]>([]);
+	const [presetParameterNames, setPresetParameterNames] = useState<string[]>(
+		[],
+	);
 
 	useEffect(() => {
 		// TODO (sasswart): test case: what if immutable parameters are used in the preset?
@@ -187,16 +189,19 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
 
 		const updatedValues = {
 			...form.values,
-			rich_parameter_values: form.values.rich_parameter_values?.map((param) => {
-				const presetParam = selectedPresetParameters.find((p) => p.Name === param.name);
-				if (presetParam) {
-					return {
-						name: param.name,
-						value: presetParam.Value,
-					};
-				}
-				return param;
-			}) ?? [],
+			rich_parameter_values:
+				form.values.rich_parameter_values?.map((param) => {
+					const presetParam = selectedPresetParameters.find(
+						(p) => p.Name === param.name,
+					);
+					if (presetParam) {
+						return {
+							name: param.name,
+							value: presetParam.Value,
+						};
+					}
+					return param;
+				}) ?? [],
 		};
 
 		form.setValues(updatedValues);

Original file line number	Diff line number	Diff line change
`@@ -269,8 +269,7 @@ func provisionEnv(`
`269`	`269`	`env = append(env, provider.ParameterEnvironmentVariable(param.Name)+"="+param.Value)`
`270`	`270`	`}`
`271`	`271`	`for _, extAuth := range externalAuth {`
`272`		`- // TODO (sasswart): what's going on with provider.GitAuthAccessTokenEnvironmentVariable here?`
`273`		`- // do we still need it? I've removed it for now.`
	`272`	`+ env = append(env, provider.GitAuthAccessTokenEnvironmentVariable(extAuth.Id)+"="+extAuth.AccessToken)`
`274`	`273`	`env = append(env, provider.ExternalAuthAccessTokenEnvironmentVariable(extAuth.Id)+"="+extAuth.AccessToken)`
`275`	`274`	`}`
`276`	`275`