refactor(site): apply minor naming improvements (#11080)

BrunoQuaresma · web-flow · commit 9d8578e0e305 · 2023-12-08T11:46:18.000-03:00
Minor naming and logic improvements to improve readability
diff --git a/site/src/pages/WorkspacePage/WorkspaceStats.tsx b/site/src/pages/WorkspacePage/WorkspaceStats.tsx
@@ -110,7 +110,7 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({
         {shouldDisplayScheduleLabel(workspace) && (
           <StatsItem
             css={styles.statsItem}
-            label={getScheduleLabel(workspace)}
+            label={scheduleLabel(workspace)}
             value={
               <div css={styles.scheduleValue}>
                 {isWorkspaceOn(workspace) ? (
@@ -335,21 +335,25 @@ const ScheduleSettingsLink = forwardRef<HTMLAnchorElement, LinkProps>(
   },
 );
 
+const hasDeadline = (workspace: Workspace): boolean => {
+  return Boolean(workspace.latest_build.deadline);
+};
+
+const hasAutoStart = (workspace: Workspace): boolean => {
+  return Boolean(workspace.autostart_schedule);
+};
+
 export const canEditDeadline = (workspace: Workspace): boolean => {
-  return isWorkspaceOn(workspace) && Boolean(workspace.latest_build.deadline);
+  return isWorkspaceOn(workspace) && hasDeadline(workspace);
 };
 
 export const shouldDisplayScheduleLabel = (workspace: Workspace): boolean => {
-  if (canEditDeadline(workspace)) {
-    return true;
-  }
-  if (isWorkspaceOn(workspace)) {
-    return false;
-  }
-  return Boolean(workspace.autostart_schedule);
+  const willAutoStop = isWorkspaceOn(workspace) && hasDeadline(workspace);
+  const willAutoStart = !isWorkspaceOn(workspace) && hasAutoStart(workspace);
+  return willAutoStop || willAutoStart;
 };
 
-const getScheduleLabel = (workspace: Workspace) => {
+const scheduleLabel = (workspace: Workspace) => {
   return isWorkspaceOn(workspace) ? "Stops" : "Starts at";
 };
 
