Remove mutation errors from alerts

BrunoQuaresma · BrunoQuaresma · commit 9ec5952f452f · 2024-01-09T12:33:47.000Z
diff --git a/site/src/pages/WorkspacePage/Workspace.stories.tsx b/site/src/pages/WorkspacePage/Workspace.stories.tsx
@@ -78,7 +78,6 @@ export const Running: Story = {
     workspace: Mocks.MockWorkspace,
     handleStart: action("start"),
     handleStop: action("stop"),
-    workspaceErrors: {},
     buildInfo: Mocks.MockBuildInfo,
     template: Mocks.MockTemplate,
   },
@@ -122,18 +121,6 @@ export const Stopping: Story = {
   },
 };
 
-export const Failed: Story = {
-  args: {
-    ...Running.args,
-    workspace: Mocks.MockFailedWorkspace,
-    workspaceErrors: {
-      buildError: Mocks.mockApiError({
-        message: "A workspace build is already active.",
-      }),
-    },
-  },
-};
-
 export const FailedWithLogs: Story = {
   args: {
     ...Running.args,
@@ -224,29 +211,6 @@ export const CantAutostart: Story = {
   },
 };
 
-export const GetBuildsError: Story = {
-  args: {
-    ...Running.args,
-    workspaceErrors: {
-      getBuildsError: Mocks.mockApiError({
-        message: "There is a problem fetching builds.",
-      }),
-    },
-  },
-};
-
-export const CancellationError: Story = {
-  args: {
-    ...Failed.args,
-    workspaceErrors: {
-      cancellationError: Mocks.mockApiError({
-        message: "Job could not be canceled.",
-      }),
-    },
-    buildLogs: <WorkspaceBuildLogsSection logs={makeFailedBuildLogs()} />,
-  },
-};
-
 export const Deprecated: Story = {
   args: {
     ...Running.args,
diff --git a/site/src/pages/WorkspacePage/Workspace.tsx b/site/src/pages/WorkspacePage/Workspace.tsx
@@ -7,7 +7,6 @@ import dayjs from "dayjs";
 import type * as TypesGen from "api/typesGenerated";
 import { Alert, AlertDetail } from "components/Alert/Alert";
 import { Stack } from "components/Stack/Stack";
-import { ErrorAlert } from "components/Alert/ErrorAlert";
 import { AgentRow } from "components/Resources/AgentRow";
 import { useTab } from "hooks";
 import {
@@ -28,13 +27,6 @@ import { ResourceCard } from "components/Resources/ResourceCard";
 import { WorkspaceNotifications } from "./WorkspaceNotifications";
 import { WorkspacePermissions } from "./permissions";
 
-export type WorkspaceError =
-  | "getBuildsError"
-  | "buildError"
-  | "cancellationError";
-
-export type WorkspaceErrors = Partial<Record<WorkspaceError, unknown>>;
-
 export interface WorkspaceProps {
   handleStart: (buildParameters?: TypesGen.WorkspaceBuildParameter[]) => void;
   handleStop: () => void;
@@ -51,7 +43,6 @@ export interface WorkspaceProps {
   canChangeVersions: boolean;
   hideSSHButton?: boolean;
   hideVSCodeDesktopButton?: boolean;
-  workspaceErrors: WorkspaceErrors;
   buildInfo?: TypesGen.BuildInfoResponse;
   sshPrefix?: string;
   template?: TypesGen.Template;
@@ -80,7 +71,6 @@ export const Workspace: FC<WorkspaceProps> = ({
   isUpdating,
   isRestarting,
   canChangeVersions,
-  workspaceErrors,
   hideSSHButton,
   hideVSCodeDesktopButton,
   buildInfo,
@@ -242,17 +232,6 @@ export const Workspace: FC<WorkspaceProps> = ({
               onRestartWorkspace={handleRestart}
             />
 
-            {Boolean(workspaceErrors.buildError) && (
-              <ErrorAlert error={workspaceErrors.buildError} dismissible />
-            )}
-
-            {Boolean(workspaceErrors.cancellationError) && (
-              <ErrorAlert
-                error={workspaceErrors.cancellationError}
-                dismissible
-              />
-            )}
-
             {workspace.latest_build.status === "deleted" && (
               <WorkspaceDeletedBanner
                 handleClick={() => navigate(`/templates`)}
diff --git a/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx b/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
@@ -74,13 +74,10 @@ export const WorkspaceReadyPage = ({
     open: boolean;
     buildParameters?: TypesGen.WorkspaceBuildParameter[];
   }>({ open: false });
-  const {
-    mutate: mutateRestartWorkspace,
-    error: restartBuildError,
-    isLoading: isRestarting,
-  } = useMutation({
-    mutationFn: restartWorkspace,
-  });
+  const { mutate: mutateRestartWorkspace, isLoading: isRestarting } =
+    useMutation({
+      mutationFn: restartWorkspace,
+    });
 
   // SSH Prefix
   const sshPrefixQuery = useQuery(deploymentSSHConfig());
@@ -221,15 +218,6 @@ export const WorkspaceReadyPage = ({
         canChangeVersions={canChangeVersions}
         hideSSHButton={featureVisibility["browser_only"]}
         hideVSCodeDesktopButton={featureVisibility["browser_only"]}
-        workspaceErrors={{
-          buildError:
-            restartBuildError ??
-            startWorkspaceMutation.error ??
-            stopWorkspaceMutation.error ??
-            deleteWorkspaceMutation.error ??
-            updateWorkspaceMutation.error,
-          cancellationError: cancelBuildMutation.error,
-        }}
         buildInfo={buildInfo}
         sshPrefix={sshPrefixQuery.data?.hostname_prefix}
         template={template}
