first tests

mtojek · mtojek · commit 9f66e1ad3f67 · 2024-07-09T12:02:03.000+02:00
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -1243,6 +1243,7 @@ func New(options *Options) *API {
 			})
 		})
 		r.Route("/notifications", func(r chi.Router) {
+			r.Use(apiKeyMiddleware)
 			r.Get("/settings", api.notificationsSettings)
 			r.Put("/settings", api.putNotificationsSettings)
 		})
diff --git a/coderd/notifications.go b/coderd/notifications.go
@@ -1,6 +1,7 @@
 package coderd
 
 import (
+	"bytes"
 	"encoding/json"
 	"net/http"
 
@@ -78,6 +79,21 @@ func (api *API) putNotificationsSettings(rw http.ResponseWriter, r *http.Request
 		return
 	}
 
+	currentSettingsJSON, err := api.Database.GetNotificationsSettings(r.Context())
+	if err != nil {
+		httpapi.Write(r.Context(), rw, http.StatusInternalServerError, codersdk.Response{
+			Message: "Failed to fetch current notification settings.",
+			Detail:  err.Error(),
+		})
+		return
+	}
+
+	if bytes.Equal(settingsJSON, []byte(currentSettingsJSON)) {
+		// See: https://www.rfc-editor.org/rfc/rfc7231#section-6.3.5
+		httpapi.Write(r.Context(), rw, http.StatusNoContent, nil)
+		return
+	}
+
 	auditor := api.Auditor.Load()
 	aReq, commitAudit := audit.InitRequest[database.NotificationsSettings](rw, &audit.RequestParams{
 		Audit:   *auditor,
diff --git a/coderd/notifications_test.go b/coderd/notifications_test.go
@@ -1,3 +1,58 @@
 package coderd_test
 
-// TODO
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/v2/coderd/coderdtest"
+	"github.com/coder/coder/v2/codersdk"
+	"github.com/coder/coder/v2/testutil"
+)
+
+func TestUpdateNotificationsSettings(t *testing.T) {
+	t.Parallel()
+
+	t.Run("Settings modified", func(t *testing.T) {
+		t.Parallel()
+
+		client := coderdtest.New(t, nil)
+		_ = coderdtest.CreateFirstUser(t, client)
+
+		// given
+		expected := codersdk.NotificationsSettings{
+			NotifierPaused: true,
+		}
+
+		ctx := testutil.Context(t, testutil.WaitShort)
+
+		// when
+		err := client.PutNotificationsSettings(ctx, expected)
+		require.NoError(t, err)
+
+		// then
+		actual, err := client.GetNotificationsSettings(ctx)
+		require.NoError(t, err)
+		require.Equal(t, expected, actual)
+	})
+
+	t.Run("Settings not modified", func(t *testing.T) {
+		t.Parallel()
+
+		client := coderdtest.New(t, nil)
+		_ = coderdtest.CreateFirstUser(t, client)
+
+		ctx := testutil.Context(t, testutil.WaitShort)
+
+		// given
+		expected := codersdk.NotificationsSettings{
+			NotifierPaused: false,
+		}
+		err := client.PutNotificationsSettings(ctx, expected)
+		require.NoError(t, err)
+
+		// then
+		err = client.PutNotificationsSettings(ctx, expected)
+		require.Error(t, err) // Error: notifications settings not modified
+	})
+}
diff --git a/codersdk/notifications.go b/codersdk/notifications.go
@@ -1,5 +1,42 @@
 package codersdk
 
+import (
+	"context"
+	"encoding/json"
+	"net/http"
+
+	"golang.org/x/xerrors"
+)
+
 type NotificationsSettings struct {
-	NotifierPaused bool `json:"notifier_paused" validate:"required"`
+	NotifierPaused bool `json:"notifier_paused"`
+}
+
+func (c *Client) GetNotificationsSettings(ctx context.Context) (NotificationsSettings, error) {
+	res, err := c.Request(ctx, http.MethodGet, "/api/v2/notifications/settings", nil)
+	if err != nil {
+		return NotificationsSettings{}, err
+	}
+	defer res.Body.Close()
+	if res.StatusCode != http.StatusOK {
+		return NotificationsSettings{}, ReadBodyAsError(res)
+	}
+	var settings NotificationsSettings
+	return settings, json.NewDecoder(res.Body).Decode(&settings)
+}
+
+func (c *Client) PutNotificationsSettings(ctx context.Context, settings NotificationsSettings) error {
+	res, err := c.Request(ctx, http.MethodPut, "/api/v2/notifications/settings", settings)
+	if err != nil {
+		return err
+	}
+	defer res.Body.Close()
+
+	if res.StatusCode == http.StatusNoContent {
+		return xerrors.New("notifications settings not modified")
+	}
+	if res.StatusCode != http.StatusOK {
+		return ReadBodyAsError(res)
+	}
+	return nil
 }
