un-skip TestAuthorizeAllEndpoints and remove always-true conditional for authzquerier unit tests

johnstcn · johnstcn · commit a0725b9dcfaa · 2023-02-03T19:01:53.000Z
diff --git a/coderd/coderdtest/authorize_test.go b/coderd/coderdtest/authorize_test.go
@@ -9,8 +9,6 @@ import (
 
 func TestAuthorizeAllEndpoints(t *testing.T) {
 	t.Parallel()
-	// TODO: DO NOT MERGE THIS
-	t.Skip("TODO: fix all the unit tests that break when this is enabled. ")
 	client, _, api := coderdtest.NewWithAPI(t, &coderdtest.Options{
 		// Required for any subdomain-based proxy tests to pass.
 		AppHostname: "*.test.coder.com",
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -181,7 +181,7 @@ func NewOptions(t *testing.T, options *Options) (func(http.Handler), context.Can
 		options.Database, options.Pubsub = dbtestutil.NewDB(t)
 	}
 	// TODO: remove this once we're ready to enable authz querier by default.
-	if strings.Contains(os.Getenv("CODER_EXPERIMENTS_TEST"), "authz_querier") || true {
+	if strings.Contains(os.Getenv("CODER_EXPERIMENTS_TEST"), "authz_querier") {
 		if options.Authorizer == nil {
 			options.Authorizer = &RecordingAuthorizer{
 				Wrapped: rbac.NewAuthorizer(prometheus.NewRegistry()),
diff --git a/enterprise/coderd/coderdenttest/coderdenttest_test.go b/enterprise/coderd/coderdenttest/coderdenttest_test.go
@@ -23,8 +23,6 @@ func TestNew(t *testing.T) {
 
 func TestAuthorizeAllEndpoints(t *testing.T) {
 	t.Parallel()
-	// TODO: DO NOT MERGE THIS
-	t.Skip("TODO: fix all the unit tests that break when this is enabled. ")
 	client, _, api := coderdenttest.NewWithAPI(t, &coderdenttest.Options{
 		Options: &coderdtest.Options{
 			// Required for any subdomain-based proxy tests to pass.

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ func NewOptions(t testing.T, options Options) (func(http.Handler), context.Can`
`181`	`181`	`options.Database, options.Pubsub = dbtestutil.NewDB(t)`
`182`	`182`	`}`
`183`	`183`	`// TODO: remove this once we're ready to enable authz querier by default.`
`184`		`- if strings.Contains(os.Getenv("CODER_EXPERIMENTS_TEST"), "authz_querier") \|\| true {`
	`184`	`+ if strings.Contains(os.Getenv("CODER_EXPERIMENTS_TEST"), "authz_querier") {`
`185`	`185`	`if options.Authorizer == nil {`
`186`	`186`	`options.Authorizer = &RecordingAuthorizer{`
`187`	`187`	`Wrapped: rbac.NewAuthorizer(prometheus.NewRegistry()),`