fix: DisplayName

mtojek · mtojek · commit a11b69eebd79 · 2023-03-31T13:14:34.000+02:00
diff --git a/coderd/templateversions.go b/coderd/templateversions.go
@@ -1596,6 +1596,7 @@ func convertTemplateVersionParameter(param database.TemplateVersionParameter) (c
 	}
 	return codersdk.TemplateVersionParameter{
 		Name:                 param.Name,
+		DisplayName:          param.DisplayName,
 		Description:          param.Description,
 		DescriptionPlaintext: descriptionPlaintext,
 		Type:                 param.Type,
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -1792,6 +1792,7 @@ func TestWorkspaceWithRichParameters(t *testing.T) {
 		firstParameterValue       = "1"
 
 		secondParameterName                = "second_parameter"
+		secondParameterDisplayName         = "Second Parameter"
 		secondParameterType                = "number"
 		secondParameterDescription         = "_This_ is second *parameter*"
 		secondParameterValue               = "2"
@@ -1813,7 +1814,8 @@ func TestWorkspaceWithRichParameters(t *testing.T) {
 								Description: firstParameterDescription,
 							},
 							{
-								Name:                secondParameterName,
+								Name: secondParameterName,
+								// FIXME: DisplayName:         secondParameterDisplayName,
 								Type:                secondParameterType,
 								Description:         secondParameterDescription,
 								ValidationMin:       1,
@@ -1850,6 +1852,7 @@ func TestWorkspaceWithRichParameters(t *testing.T) {
 	require.Equal(t, firstParameterDescriptionPlaintext, templateRichParameters[0].DescriptionPlaintext)
 	require.Equal(t, codersdk.ValidationMonotonicOrder(""), templateRichParameters[0].ValidationMonotonic) // no validation for string
 	require.Equal(t, secondParameterName, templateRichParameters[1].Name)
+	require.Equal(t, secondParameterDisplayName, templateRichParameters[1].DisplayName)
 	require.Equal(t, secondParameterType, templateRichParameters[1].Type)
 	require.Equal(t, secondParameterDescription, templateRichParameters[1].Description)
 	require.Equal(t, secondParameterDescriptionPlaintext, templateRichParameters[1].DescriptionPlaintext)
diff --git a/codersdk/templateversions.go b/codersdk/templateversions.go
@@ -41,6 +41,7 @@ const (
 // TemplateVersionParameter represents a parameter for a template version.
 type TemplateVersionParameter struct {
 	Name                 string                           `json:"name"`
+	DisplayName          string                           `json:"display_name"`
 	Description          string                           `json:"description"`
 	DescriptionPlaintext string                           `json:"description_plaintext"`
 	Type                 string                           `json:"type" enums:"string,number,bool,list(string)"`

Original file line number	Diff line number	Diff line change
`@@ -1596,6 +1596,7 @@ func convertTemplateVersionParameter(param database.TemplateVersionParameter) (c`
`1596`	`1596`	`}`
`1597`	`1597`	`return codersdk.TemplateVersionParameter{`
`1598`	`1598`	`Name: param.Name,`
	`1599`	`+ DisplayName: param.DisplayName,`
`1599`	`1600`	`Description: param.Description,`
`1600`	`1601`	`DescriptionPlaintext: descriptionPlaintext,`
`1601`	`1602`	`Type: param.Type,`