Refactor key refresh to minimize lock duration

sreya · sreya · commit a1d4b46917ae · 2024-10-04T06:51:00.000Z
diff --git a/enterprise/wsproxy/keycache.go b/enterprise/wsproxy/keycache.go
@@ -148,14 +148,14 @@ func checkKey(key codersdk.CryptoKey, sequence int32, now time.Time) (codersdk.C
 
 // refresh fetches the keys from the control plane and updates the cache.
 func (k *CryptoKeyCache) refresh() {
+	now := k.Clock.Now("CryptoKeyCache", "refresh")
+	k.mu.Lock()
+
 	if k.closed {
+		k.mu.Unlock()
 		return
 	}
 
-	now := k.Clock.Now("CryptoKeyCache", "refresh")
-
-	k.mu.Lock()
-
 	// If something's already fetching, we don't need to do anything.
 	if k.fetching {
 		k.mu.Unlock()
