feat: Implement database.IsUniqueViolation

mafredri · mafredri · commit a1da1fe7c9e4 · 2022-08-24T15:43:27.000+03:00
diff --git a/coderd/database/errors.go b/coderd/database/errors.go
@@ -0,0 +1,30 @@
+package database
+
+import (
+	"errors"
+
+	"github.com/lib/pq"
+)
+
+// UniqueConstraint represents a named unique constraint on a table.
+type UniqueConstraint string
+
+// UniqueConstrain enums.
+// TODO(mafredri): Generate these from the database schema.
+const (
+	UniqueConstraintAny                       UniqueConstraint = ""
+	UniqueConstraintWorkspacesOwnerIDLowerIdx UniqueConstraint = "workspaces_owner_id_lower_idx"
+)
+
+func IsUniqueViolation(err error, uniqueConstraint UniqueConstraint) bool {
+	var pqErr *pq.Error
+	if errors.As(err, &pqErr) {
+		if pqErr.Code.Name() == "unique_violation" {
+			if pqErr.Constraint == string(uniqueConstraint) || uniqueConstraint == UniqueConstraintAny {
+				return true
+			}
+		}
+	}
+
+	return false
+}
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -14,7 +14,6 @@ import (
 
 	"github.com/go-chi/chi/v5"
 	"github.com/google/uuid"
-	"github.com/lib/pq"
 	"github.com/moby/moby/pkg/namesgenerator"
 	"golang.org/x/sync/errgroup"
 	"golang.org/x/xerrors"
@@ -520,10 +519,8 @@ func (api *API) patchWorkspace(rw http.ResponseWriter, r *http.Request) {
 			})
 			return
 		}
-		// Check if we triggered the one-unique-name-per-owner
-		// constraint.
-		var pqErr *pq.Error
-		if errors.As(err, &pqErr) && pqErr.Code.Name() == "unique_violation" {
+		// Check if the name was already in use.
+		if database.IsUniqueViolation(err, database.UniqueConstraintWorkspacesOwnerIDLowerIdx) {
 			httpapi.Write(rw, http.StatusConflict, codersdk.Response{
 				Message: fmt.Sprintf("Workspace %q already exists.", req.Name),
 				Validations: []codersdk.ValidationError{{
@@ -533,7 +530,6 @@ func (api *API) patchWorkspace(rw http.ResponseWriter, r *http.Request) {
 			})
 			return
 		}
-
 		httpapi.Write(rw, http.StatusInternalServerError, codersdk.Response{
 			Message: "Internal error updating workspace.",
 			Detail:  err.Error(),
