Skip to content

Commit a2faf9f

Browse files
committed
display on fe
1 parent edc99ef commit a2faf9f

File tree

2 files changed

+32
-39
lines changed

2 files changed

+32
-39
lines changed

site/src/modules/provisioners/ProvisionerGroup.tsx

Lines changed: 25 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { createDayString } from "utils/createDayString";
2727
import { docs } from "utils/docs";
2828
import { ProvisionerTag } from "./ProvisionerTag";
2929

30-
type ProvisionerGroupType = "builtin" | "psk" | "key";
30+
type ProvisionerGroupType = "builtin" | "userAuth" | "psk" | "key";
3131

3232
interface ProvisionerGroupProps {
3333
readonly buildInfo: BuildInfoResponse;
@@ -62,7 +62,6 @@ export const ProvisionerGroup: FC<ProvisionerGroupProps> = ({
6262
return null;
6363
}
6464

65-
const daemonScope = firstProvisioner.tags.scope || "organization";
6665
const allProvisionersAreSameVersion = provisioners.every(
6766
(it) => it.version === firstProvisioner.version,
6867
);
@@ -73,9 +72,6 @@ export const ProvisionerGroup: FC<ProvisionerGroupProps> = ({
7372
provisioners.length === 1
7473
? "1 provisioner"
7574
: `${provisioners.length} provisioners`;
76-
const extraTags = Object.entries(keyTags).filter(
77-
([key]) => key !== "scope" && key !== "owner",
78-
);
7975

8076
let warnings = 0;
8177
let provisionersWithWarnings = 0;
@@ -102,9 +98,6 @@ export const ProvisionerGroup: FC<ProvisionerGroupProps> = ({
10298
? "1 provisioner"
10399
: `${provisionersWithWarnings} provisioners`;
104100

105-
const hasMultipleTagVariants =
106-
type === "psk" && provisioners.some((it) => !isSimpleTagSet(it.tags));
107-
108101
return (
109102
<div
110103
css={[
@@ -142,6 +135,7 @@ export const ProvisionerGroup: FC<ProvisionerGroupProps> = ({
142135
</span>
143136
</>
144137
)}
138+
{type === "userAuth" && <UserAuthProvisionerTitle />}
145139

146140
{type === "psk" && <PskProvisionerTitle />}
147141
{type === "key" && (
@@ -168,28 +162,8 @@ export const ProvisionerGroup: FC<ProvisionerGroupProps> = ({
168162
justifyContent: "right",
169163
}}
170164
>
171-
{!hasMultipleTagVariants ? (
172-
<Tooltip title="Scope">
173-
<Pill
174-
size="lg"
175-
icon={
176-
daemonScope === "organization" ? (
177-
<BusinessIcon />
178-
) : (
179-
<PersonIcon />
180-
)
181-
}
182-
>
183-
<span css={{ textTransform: "capitalize" }}>{daemonScope}</span>
184-
</Pill>
185-
</Tooltip>
186-
) : (
187-
<Pill size="lg" icon={<TagIcon />}>
188-
Multiple tags
189-
</Pill>
190-
)}
191165
{type === "key" &&
192-
extraTags.map(([key, value]) => (
166+
Object.entries(keyTags).map(([key, value]) => (
193167
<ProvisionerTag key={key} tagName={key} tagValue={value} />
194168
))}
195169
</div>
@@ -248,9 +222,7 @@ export const ProvisionerGroup: FC<ProvisionerGroupProps> = ({
248222
)}
249223
</span>
250224
</div>
251-
{hasMultipleTagVariants && (
252-
<PskProvisionerTags tags={provisioner.tags} />
253-
)}
225+
<PskProvisionerTags tags={provisioner.tags} />
254226
</Stack>
255227
</div>
256228
))}
@@ -413,6 +385,27 @@ const BuiltinProvisionerTitle: FC = () => {
413385
);
414386
};
415387

388+
const UserAuthProvisionerTitle: FC = () => {
389+
return (
390+
<h4 css={styles.groupTitle}>
391+
<Stack direction="row" alignItems="end" spacing={1}>
392+
<span>User provisioners</span>
393+
<HelpTooltip>
394+
<HelpTooltipTrigger />
395+
<HelpTooltipContent>
396+
<HelpTooltipTitle>User provisioners</HelpTooltipTitle>
397+
<HelpTooltipText>
398+
These provisioners all use user session authentication. User
399+
provisioners can be scoped to the user or organization.{" "}
400+
<Link href={docs("/")}>Learn more&hellip;</Link>
401+
</HelpTooltipText>
402+
</HelpTooltipContent>
403+
</HelpTooltip>
404+
</Stack>
405+
</h4>
406+
);
407+
};
408+
416409
const PskProvisionerTitle: FC = () => {
417410
return (
418411
<h4 css={styles.groupTitle}>

site/src/pages/ManagementSettingsPage/OrganizationProvisionersPageView.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,13 @@ const ViewContent: FC<ViewContentProps> = ({ buildInfo, provisioners }) => {
113113
{provisioners.map((group) => {
114114
const type = getGroupType(group.key);
115115

116-
// We intentionally hide user-authenticated provisioners for now
117-
// because there are 1. some grouping issues on the backend and 2. we
118-
// should ideally group them by the user who authenticated them, and
119-
// not just lump them all together.
120-
if (type === "userAuth") {
121-
return null;
122-
}
116+
// // We intentionally hide user-authenticated provisioners for now
117+
// // because there are 1. some grouping issues on the backend and 2. we
118+
// // should ideally group them by the user who authenticated them, and
119+
// // not just lump them all together.
120+
// if (type === "userAuth") {
121+
// return null;
122+
// }
123123

124124
return (
125125
<ProvisionerGroup

0 commit comments

Comments
 (0)