Move components and fix build errors

BrunoQuaresma · BrunoQuaresma · commit a3c4908c51bf · 2025-05-12T18:45:34.000Z
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/DownloadLogsDialog.stories.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/DownloadLogsDialog.stories.tsx
@@ -6,7 +6,7 @@ import { withDesktopViewport } from "testHelpers/storybook";
 import { DownloadLogsDialog } from "./DownloadLogsDialog";
 
 const meta: Meta<typeof DownloadLogsDialog> = {
-	title: "pages/WorkspacePage/DownloadLogsDialog",
+	title: "modules/workspaces/DownloadLogsDialog",
 	component: DownloadLogsDialog,
 	args: {
 		open: true,
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/DownloadLogsDialog.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/DownloadLogsDialog.tsx
@@ -221,8 +221,9 @@ const DownloadingItem: FC<DownloadingItemProps> = ({ file, giveUpTimeMs }) => {
 function humanBlobSize(size: number) {
 	const BLOB_SIZE_UNITS = ["B", "KB", "MB", "GB", "TB"] as const;
 	let i = 0;
-	while (size > 1024 && i < BLOB_SIZE_UNITS.length) {
-		size /= 1024;
+	let sizeIterator = size;
+	while (sizeIterator > 1024 && i < BLOB_SIZE_UNITS.length) {
+		sizeIterator /= 1024;
 		i++;
 	}
 
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/UpdateBuildParametersDialog.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/UpdateBuildParametersDialog.tsx
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceMoreActions.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceMoreActions.tsx
@@ -17,15 +17,15 @@ import {
 	CopyIcon,
 	DownloadIcon,
 } from "lucide-react";
-import { UpdateBuildParametersDialog } from "pages/WorkspacePage/UpdateBuildParametersDialog";
-import { DownloadLogsDialog } from "pages/WorkspacePage/WorkspaceActions/DownloadLogsDialog";
+import { UpdateBuildParametersDialog } from "./UpdateBuildParametersDialog";
+import { DownloadLogsDialog } from "./DownloadLogsDialog";
 import { useState, type FC } from "react";
 import { useMutation, useQueryClient } from "react-query";
 import { Link as RouterLink } from "react-router-dom";
 import { ChangeWorkspaceVersionDialog } from "./ChangeWorkspaceVersionDialog";
 import { WorkspaceDeleteDialog } from "./WorkspaceDeleteDialog";
 import type { WorkspacePermissions } from "../permissions";
-import { useWorkspaceDuplication } from "pages/CreateWorkspacePage/useWorkspaceDuplication";
+import { useWorkspaceDuplication } from "./useWorkspaceDuplication";
 
 type WorkspaceMoreActionsProps = {
 	workspace: Workspace;
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/useWorkspaceDuplication.test.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/useWorkspaceDuplication.test.tsx
@@ -5,7 +5,7 @@ import {
 	type GetLocationSnapshot,
 	renderHookWithAuth,
 } from "testHelpers/hooks";
-import CreateWorkspacePage from "./CreateWorkspacePage";
+import CreateWorkspacePage from "../../../pages/CreateWorkspacePage/CreateWorkspacePage";
 import { useWorkspaceDuplication } from "./useWorkspaceDuplication";
 
 function render(workspace?: Workspace) {
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/useWorkspaceDuplication.ts b/site/src/modules/workspaces/WorkspaceMoreActions/useWorkspaceDuplication.ts
@@ -4,7 +4,7 @@ import { linkToTemplate, useLinks } from "modules/navigation";
 import { useCallback } from "react";
 import { useQuery } from "react-query";
 import { useNavigate } from "react-router-dom";
-import type { CreateWorkspaceMode } from "./CreateWorkspacePage";
+import type { CreateWorkspaceMode } from "../../../pages/CreateWorkspacePage/CreateWorkspacePage";
 
 function getDuplicationUrlParams(
 	workspaceParams: readonly WorkspaceBuildParameter[],
diff --git a/site/src/modules/workspaces/WorkspaceUpdateDialogs.tsx b/site/src/modules/workspaces/WorkspaceUpdateDialogs.tsx
@@ -8,7 +8,7 @@ import type {
 } from "api/typesGenerated";
 import { ConfirmDialog } from "components/Dialogs/ConfirmDialog/ConfirmDialog";
 import { MemoizedInlineMarkdown } from "components/Markdown/Markdown";
-import { UpdateBuildParametersDialog } from "pages/WorkspacePage/UpdateBuildParametersDialog";
+import { UpdateBuildParametersDialog } from "modules/workspaces/WorkspaceMoreActions/UpdateBuildParametersDialog";
 import { type FC, useState } from "react";
 import { useMutation, useQueryClient } from "react-query";
 
diff --git a/site/src/pages/WorkspacePage/Workspace.stories.tsx b/site/src/pages/WorkspacePage/Workspace.stories.tsx
@@ -21,8 +21,9 @@ const createTimestamp = (
 const permissions: WorkspacePermissions = {
 	readWorkspace: true,
 	updateWorkspace: true,
-	updateTemplate: true,
-	viewDeploymentConfig: true,
+	updateWorkspaceVersion: true,
+	deploymentConfig: true,
+	deleteFailedWorkspace: true,
 };
 
 const meta: Meta<typeof Workspace> = {
diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx
@@ -157,7 +157,13 @@ export const Failed: Story = {
 export const FailedWithDebug: Story = {
 	args: {
 		workspace: Mocks.MockFailedWorkspace,
-		canDebug: true,
+		permissions: {
+			deploymentConfig: true,
+			deleteFailedWorkspace: true,
+			readWorkspace: true,
+			updateWorkspace: true,
+			updateWorkspaceVersion: true,
+		},
 	},
 };
 
diff --git a/site/src/pages/WorkspacePage/WorkspaceNotifications/WorkspaceNotifications.stories.tsx b/site/src/pages/WorkspacePage/WorkspaceNotifications/WorkspaceNotifications.stories.tsx
@@ -10,12 +10,14 @@ import {
 } from "testHelpers/entities";
 import { withDashboardProvider } from "testHelpers/storybook";
 import { WorkspaceNotifications } from "./WorkspaceNotifications";
+import type { WorkspacePermissions } from "modules/workspaces/permissions";
 
-const defaultPermissions = {
+const defaultPermissions: WorkspacePermissions = {
 	readWorkspace: true,
-	updateTemplate: true,
+	updateWorkspaceVersion: true,
 	updateWorkspace: true,
-	viewDeploymentConfig: true,
+	deploymentConfig: true,
+	deleteFailedWorkspace: true,
 };
 
 const meta: Meta<typeof WorkspaceNotifications> = {
diff --git a/site/src/pages/WorkspacePage/WorkspaceTopbar.stories.tsx b/site/src/pages/WorkspacePage/WorkspaceTopbar.stories.tsx
@@ -33,7 +33,13 @@ const meta: Meta<typeof WorkspaceTopbar> = {
 		workspace: baseWorkspace,
 		template: MockTemplate,
 		latestVersion: MockTemplateVersion,
-		canUpdateWorkspace: true,
+		permissions: {
+			readWorkspace: true,
+			updateWorkspaceVersion: true,
+			updateWorkspace: true,
+			deploymentConfig: true,
+			deleteFailedWorkspace: true,
+		},
 	},
 	parameters: {
 		layout: "fullscreen",
diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.tsx
@@ -50,14 +50,13 @@ const WorkspaceParametersPage: FC = () => {
 	const template = templateQuery.data;
 
 	// Permissions
-	const checks =
-		workspace && template ? workspaceChecks(workspace, template) : {};
+	const checks = workspace && template ? workspaceChecks(workspace) : {};
 	const permissionsQuery = useQuery({
 		...checkAuthorization({ checks }),
 		enabled: workspace !== undefined && template !== undefined,
 	});
 	const permissions = permissionsQuery.data as WorkspacePermissions | undefined;
-	const canChangeVersions = Boolean(permissions?.updateTemplate);
+	const canChangeVersions = Boolean(permissions?.updateWorkspaceVersion);
 
 	return (
 		<>
