Address most review comments

ammario · ammario · commit a3d87b8f1fa3 · 2022-09-01T17:14:20.000Z
diff --git a/coderd/database/migrations/000042_agent_stats.up.sql b/coderd/database/migrations/000042_agent_stats.up.sql
@@ -1,12 +1,12 @@
 CREATE TABLE agent_stats (
-	id uuid NOT NULL,
-	PRIMARY KEY (id),
+    id uuid NOT NULL,
+    PRIMARY KEY (id),
     created_at timestamptz NOT NULL,
     user_id uuid NOT NULL,
     agent_id uuid NOT NULL,
     workspace_id uuid NOT NULL,
     template_id uuid NOT NULL,
-	payload jsonb NOT NULL
+    payload jsonb NOT NULL
 );
 
 -- We use created_at for DAU analysis and pruning.
diff --git a/codersdk/metrics.go b/codersdk/metrics.go
@@ -139,6 +139,8 @@ type AgentStatsReportRequest struct {
 // request by the agent.
 type AgentStatsReportResponse struct {
 	NumConns int64 `json:"num_comms"`
-	RxBytes  int64 `json:"rx_bytes"`
-	TxBytes  int64 `json:"tx_bytes"`
+	// RxBytes is the number of received bytes.
+	RxBytes int64 `json:"rx_bytes"`
+	// TxBytes is the number of received bytes.
+	TxBytes int64 `json:"tx_bytes"`
 }
diff --git a/site/package.json b/site/package.json
@@ -48,11 +48,10 @@
     "history": "5.3.0",
     "i18next": "21.9.1",
     "just-debounce-it": "3.0.1",
-    "moment": "^2.29.4",
     "react": "18.2.0",
     "react-chartjs-2": "^4.3.1",
     "react-dom": "18.2.0",
-    "react-helmet-async": "^1.3.0",
+    "react-helmet-async": "1.3.0",
     "react-i18next": "11.18.4",
     "react-markdown": "8.0.3",
     "react-router-dom": "^6.3.0",
diff --git a/site/src/pages/TemplatePage/DAUChart.test.tsx b/site/src/pages/TemplatePage/DAUChart.test.tsx
@@ -4,6 +4,7 @@ import { DAUChart, Language } from "./DAUChart"
 import { screen } from "@testing-library/react"
 import { ResizeObserver } from "resize-observer"
 
+// The Chart performs dynamic resizes which fail in tests without this.
 Object.defineProperty(window, "ResizeObserver", {
   value: ResizeObserver,
 })
diff --git a/site/src/pages/TemplatePage/DAUChart.tsx b/site/src/pages/TemplatePage/DAUChart.tsx
@@ -17,7 +17,7 @@ import {
 import { Stack } from "components/Stack/Stack"
 import { HelpTooltip, HelpTooltipText, HelpTooltipTitle } from "components/Tooltips/HelpTooltip"
 import { WorkspaceSection } from "components/WorkspaceSection/WorkspaceSection"
-import moment from "moment"
+import dayjs from "dayjs"
 import { FC } from "react"
 import { Line } from "react-chartjs-2"
 import * as TypesGen from "../../api/typesGenerated"
@@ -55,7 +55,7 @@ export const DAUChart: FC<DAUChartProps> = ({ templateDAUs: templateMetricsData
   }
 
   const labels = templateMetricsData.entries.map((val) => {
-    return moment(val.date).format("l")
+    return dayjs(val.date).format("YYYY-MM-DD")
   })
 
   const data = templateMetricsData.entries.map((val) => {
diff --git a/site/yarn.lock b/site/yarn.lock
@@ -10386,11 +10386,6 @@ mock-socket@^9.1.0:
   resolved "https://registry.yarnpkg.com/mock-socket/-/mock-socket-9.1.5.tgz#2c4e44922ad556843b6dfe09d14ed8041fa2cdeb"
   integrity sha512-3DeNIcsQixWHHKk6NdoBhWI4t1VMj5/HzfnI1rE/pLl5qKx7+gd4DNA07ehTaZ6MoUU053si6Hd+YtiM/tQZfg==
 
-moment@^2.29.4:
-  version "2.29.4"
-  resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"
-  integrity sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==
-
 moo-color@^1.0.2:
   version "1.0.3"
   resolved "https://registry.yarnpkg.com/moo-color/-/moo-color-1.0.3.tgz#d56435f8359c8284d83ac58016df7427febece74"
@@ -11899,7 +11894,7 @@ react-fast-compare@^3.0.1, react-fast-compare@^3.2.0:
   resolved "https://registry.yarnpkg.com/react-fast-compare/-/react-fast-compare-3.2.0.tgz#641a9da81b6a6320f270e89724fb45a0b39e43bb"
   integrity sha512-rtGImPZ0YyLrscKI9xTpV8psd6I8VAtjKCzQDlzyDvqJA8XOW78TXYQwNRNd8g8JZnDu8q9Fu/1v4HPAVwVdHA==
 
-react-helmet-async@^1.0.7, react-helmet-async@^1.3.0:
+react-helmet-async@1.3.0, react-helmet-async@^1.0.7:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/react-helmet-async/-/react-helmet-async-1.3.0.tgz#7bd5bf8c5c69ea9f02f6083f14ce33ef545c222e"
   integrity sha512-9jZ57/dAn9t3q6hneQS0wukqC2ENOBgMNVEhb/ZG9ZSxUetzVIw4iAmEU38IaVg3QGYauQPhSeUTuIUtFglWpg==
