test: scaletest/reconnectingpty: use TerminalReader

mtojek · mtojek · commit a474ffddc2d1 · 2024-10-15T14:46:10.000+02:00
diff --git a/scaletest/reconnectingpty/run_test.go b/scaletest/reconnectingpty/run_test.go
@@ -22,7 +22,6 @@ import (
 
 func Test_Runner(t *testing.T) {
 	t.Parallel()
-	t.Skip("https://github.com/coder/internal/issues/98")
 
 	t.Run("OK", func(t *testing.T) {
 		t.Parallel()
@@ -43,14 +42,16 @@ func Test_Runner(t *testing.T) {
 
 		logs := bytes.NewBuffer(nil)
 		err := runner.Run(ctx, "1", logs)
-		logStr := logs.String()
-		t.Log("Runner logs:\n\n" + logStr)
 		require.NoError(t, err)
 
-		require.Contains(t, logStr, "Output:")
+		tr := testutil.NewTerminalReader(t, logs)
+		err = tr.ReadUntilString(ctx, "Output:")
+		require.NoError(t, err)
+
 		// OSX: Output:\n\thello world\n
 		// Win: Output:\n\t\x1b[2J\x1b[m\x1b[H\x1b]0;Administrator: C:\\Program Files\\PowerShell\\7\\pwsh.exe\a\x1b[?25hhello world\n
-		require.Contains(t, logStr, "hello world\n")
+		err = tr.ReadUntilString(ctx, "hello world")
+		require.NoError(t, err)
 	})
 
 	t.Run("NoLogOutput", func(t *testing.T) {
