Cleanup error handle

f0ssel · f0ssel · commit a511f6ad91db · 2022-04-18T23:37:28.000Z
diff --git a/coderts/generate.go b/coderts/generate.go
@@ -89,8 +89,8 @@ func handleTypeSpec(typeSpec *ast.TypeSpec, pos token.Position) (string, error)
 				continue
 			}
 
-			fieldName, err := toJSONField(field)
-			if err != nil || fieldType == "" {
+			fieldName := toJSONField(field)
+			if fieldType == "" {
 				continue
 			}
 
@@ -169,7 +169,7 @@ func toTsType(fieldType string) string {
 	return fieldType
 }
 
-func toJSONField(field *ast.Field) (string, error) {
+func toJSONField(field *ast.Field) string {
 	if field.Tag != nil && field.Tag.Value != "" {
 		fieldName := strings.Trim(field.Tag.Value, "`")
 		for _, pair := range strings.Split(fieldName, " ") {
@@ -178,10 +178,10 @@ func toJSONField(field *ast.Field) (string, error) {
 				fieldName = strings.Trim(fieldName, `"`)
 				fieldName = strings.Split(fieldName, ",")[0]
 
-				return fieldName, nil
+				return fieldName
 			}
 		}
 	}
 
-	return "", xerrors.New("no json tag")
+	return ""
 }

Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,8 @@ func handleTypeSpec(typeSpec *ast.TypeSpec, pos token.Position) (string, error)`
`89`	`89`	`continue`
`90`	`90`	`}`
`91`	`91`
`92`		`- fieldName, err := toJSONField(field)`
`93`		`- if err != nil \|\| fieldType == "" {`
	`92`	`+ fieldName := toJSONField(field)`
	`93`	`+ if fieldType == "" {`
`94`	`94`	`continue`
`95`	`95`	`}`
`96`	`96`
`@@ -169,7 +169,7 @@ func toTsType(fieldType string) string {`
`169`	`169`	`return fieldType`
`170`	`170`	`}`
`171`	`171`
`172`		`-func toJSONField(field *ast.Field) (string, error) {`
	`172`	`+func toJSONField(field *ast.Field) string {`
`173`	`173`	`if field.Tag != nil && field.Tag.Value != "" {`
`174`	`174`	fieldName := strings.Trim(field.Tag.Value, "`")
`175`	`175`	`for _, pair := range strings.Split(fieldName, " ") {`
`@@ -178,10 +178,10 @@ func toJSONField(field *ast.Field) (string, error) {`
`178`	`178`	fieldName = strings.Trim(fieldName, `"`)
`179`	`179`	`fieldName = strings.Split(fieldName, ",")[0]`
`180`	`180`
`181`		`- return fieldName, nil`
	`181`	`+ return fieldName`
`182`	`182`	`}`
`183`	`183`	`}`
`184`	`184`	`}`
`185`	`185`
`186`		`- return "", xerrors.New("no json tag")`
	`186`	`+ return ""`
`187`	`187`	`}`