Skip to content

Commit a70d24c

Browse files
BrunoQuaresmaBrunoQuaresma
committed
Remove ynecessary async
1 parent 4c61c01 commit a70d24c

File tree

2 files changed

+55
-61
lines changed

2 files changed

+55
-61
lines changed

‎site/src/contexts/ProxyContext.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ describe("ProxyContextSelection", () => {
357357
regions,
358358
}),
359359
),
360-
http.get("/api/v2/workspaceproxies", async () =>
360+
http.get("/api/v2/workspaceproxies", () =>
361361
HttpResponse.json({ regions }),
362362
),
363363
);

‎site/src/testHelpers/handlers.ts

Lines changed: 54 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -7,154 +7,148 @@ import * as M from "./entities";
77
import { MockGroup, MockWorkspaceQuota } from "./entities";
88

99
export const handlers = [
10-
http.get("/api/v2/templates/:templateId/daus", async () => {
10+
http.get("/api/v2/templates/:templateId/daus", () => {
1111
return HttpResponse.json(M.MockTemplateDAUResponse);
1212
}),
1313

14-
http.get("/api/v2/insights/daus", async () => {
14+
http.get("/api/v2/insights/daus", () => {
1515
return HttpResponse.json(M.MockDeploymentDAUResponse);
1616
}),
1717
// Workspace proxies
18-
http.get("/api/v2/regions", async () => {
18+
http.get("/api/v2/regions", () => {
1919
return HttpResponse.json({
2020
regions: M.MockWorkspaceProxies,
2121
});
2222
}),
23-
http.get("/api/v2/workspaceproxies", async () => {
23+
http.get("/api/v2/workspaceproxies", () => {
2424
return HttpResponse.json({
2525
regions: M.MockWorkspaceProxies,
2626
});
2727
}),
2828
// build info
29-
http.get("/api/v2/buildinfo", async () => {
29+
http.get("/api/v2/buildinfo", () => {
3030
return HttpResponse.json(M.MockBuildInfo);
3131
}),
3232

3333
// experiments
34-
http.get("/api/v2/experiments", async () => {
34+
http.get("/api/v2/experiments", () => {
3535
return HttpResponse.json(M.MockExperiments);
3636
}),
3737

3838
// update check
39-
http.get("/api/v2/updatecheck", async () => {
39+
http.get("/api/v2/updatecheck", () => {
4040
return HttpResponse.json(M.MockUpdateCheck);
4141
}),
4242

4343
// organizations
44-
http.get("/api/v2/organizations/:organizationId", async () => {
44+
http.get("/api/v2/organizations/:organizationId", () => {
4545
return HttpResponse.json(M.MockOrganization);
4646
}),
4747
http.get("api/v2/organizations/:organizationId/templates/examples", () => {
4848
return HttpResponse.json([M.MockTemplateExample, M.MockTemplateExample2]);
4949
}),
5050
http.get(
5151
"/api/v2/organizations/:organizationId/templates/:templateId",
52-
async () => {
52+
() => {
5353
return HttpResponse.json(M.MockTemplate);
5454
},
5555
),
56-
http.get("/api/v2/organizations/:organizationId/templates", async () => {
56+
http.get("/api/v2/organizations/:organizationId/templates", () => {
5757
return HttpResponse.json([M.MockTemplate]);
5858
}),
5959

6060
// templates
61-
http.get("/api/v2/templates/:templateId", async () => {
61+
http.get("/api/v2/templates/:templateId", () => {
6262
return HttpResponse.json(M.MockTemplate);
6363
}),
64-
http.get("/api/v2/templates/:templateId/versions", async () => {
64+
http.get("/api/v2/templates/:templateId/versions", () => {
6565
return HttpResponse.json([M.MockTemplateVersion2, M.MockTemplateVersion]);
6666
}),
67-
http.patch("/api/v2/templates/:templateId/versions", async () => {
67+
http.patch("/api/v2/templates/:templateId/versions", () => {
6868
return new HttpResponse(null, { status: 200 });
6969
}),
70-
http.patch("/api/v2/templates/:templateId", async () => {
70+
http.patch("/api/v2/templates/:templateId", () => {
7171
return HttpResponse.json(M.MockTemplate);
7272
}),
73-
http.get("/api/v2/templateversions/:templateVersionId", async () => {
73+
http.get("/api/v2/templateversions/:templateVersionId", () => {
7474
return HttpResponse.json(M.MockTemplateVersion);
7575
}),
76-
http.get(
77-
"/api/v2/templateversions/:templateVersionId/resources",
78-
async () => {
79-
return HttpResponse.json([
80-
M.MockWorkspaceResource,
81-
M.MockWorkspaceVolumeResource,
82-
M.MockWorkspaceImageResource,
83-
M.MockWorkspaceContainerResource,
84-
]);
85-
},
86-
),
76+
http.get("/api/v2/templateversions/:templateVersionId/resources", () => {
77+
return HttpResponse.json([
78+
M.MockWorkspaceResource,
79+
M.MockWorkspaceVolumeResource,
80+
M.MockWorkspaceImageResource,
81+
M.MockWorkspaceContainerResource,
82+
]);
83+
}),
8784
http.get(
8885
"/api/v2/templateversions/:templateVersionId/rich-parameters",
89-
async () => {
90-
return HttpResponse.json([]);
91-
},
92-
),
93-
http.get(
94-
"/api/v2/templateversions/:templateVersionId/external-auth",
95-
async () => {
86+
() => {
9687
return HttpResponse.json([]);
9788
},
9889
),
99-
http.get("/api/v2/templateversions/:templateversionId/logs", async () => {
90+
http.get("/api/v2/templateversions/:templateVersionId/external-auth", () => {
91+
return HttpResponse.json([]);
92+
}),
93+
http.get("/api/v2/templateversions/:templateversionId/logs", () => {
10094
return HttpResponse.json(M.MockWorkspaceBuildLogs);
10195
}),
10296
http.get(
10397
"api/v2/organizations/:organizationId/templates/:templateName/versions/:templateVersionName",
104-
async () => {
98+
() => {
10599
return HttpResponse.json(M.MockTemplateVersion);
106100
},
107101
),
108102
http.get(
109103
"api/v2/organizations/:organizationId/templates/:templateName/versions/:templateVersionName/previous",
110-
async () => {
104+
() => {
111105
return HttpResponse.json(M.MockTemplateVersion2);
112106
},
113107
),
114-
http.delete("/api/v2/templates/:templateId", async () => {
108+
http.delete("/api/v2/templates/:templateId", () => {
115109
return HttpResponse.json(M.MockTemplate);
116110
}),
117111

118112
// users
119-
http.get("/api/v2/users", async () => {
113+
http.get("/api/v2/users", () => {
120114
return HttpResponse.json({
121115
users: [M.MockUser, M.MockUser2, M.SuspendedMockUser],
122116
count: 26,
123117
});
124118
}),
125-
http.post("/api/v2/users", async () => {
119+
http.post("/api/v2/users", () => {
126120
return HttpResponse.json(M.MockUser);
127121
}),
128-
http.get("/api/v2/users/:userid/login-type", async () => {
122+
http.get("/api/v2/users/:userid/login-type", () => {
129123
return HttpResponse.json({
130124
login_type: "password",
131125
});
132126
}),
133127
http.get("/api/v2/users/me/organizations", () => {
134128
return HttpResponse.json([M.MockOrganization]);
135129
}),
136-
http.get("/api/v2/users/me/organizations/:organizationId", async () => {
130+
http.get("/api/v2/users/me/organizations/:organizationId", () => {
137131
return HttpResponse.json(M.MockOrganization);
138132
}),
139-
http.post("/api/v2/users/login", async () => {
133+
http.post("/api/v2/users/login", () => {
140134
return HttpResponse.json(M.MockSessionToken);
141135
}),
142-
http.post("/api/v2/users/logout", async () => {
136+
http.post("/api/v2/users/logout", () => {
143137
return new HttpResponse(null, { status: 200 });
144138
}),
145-
http.get("/api/v2/users/me", async () => {
139+
http.get("/api/v2/users/me", () => {
146140
return HttpResponse.json(M.MockUser);
147141
}),
148-
http.get("/api/v2/users/me/keys", async () => {
142+
http.get("/api/v2/users/me/keys", () => {
149143
return HttpResponse.json(M.MockAPIKey);
150144
}),
151-
http.get("/api/v2/users/authmethods", async () => {
145+
http.get("/api/v2/users/authmethods", () => {
152146
return HttpResponse.json(M.MockAuthMethodsPasswordOnly);
153147
}),
154-
http.get("/api/v2/users/roles", async () => {
148+
http.get("/api/v2/users/roles", () => {
155149
return HttpResponse.json(M.MockSiteRoles);
156150
}),
157-
http.post("/api/v2/authcheck", async () => {
151+
http.post("/api/v2/authcheck", () => {
158152
const permissions = [
159153
...Object.keys(permissionsToCheck),
160154
"canUpdateTemplate",
@@ -169,38 +163,38 @@ export const handlers = [
169163

170164
return HttpResponse.json(response);
171165
}),
172-
http.get("/api/v2/users/:userId/gitsshkey", async () => {
166+
http.get("/api/v2/users/:userId/gitsshkey", () => {
173167
return HttpResponse.json(M.MockGitSSHKey);
174168
}),
175-
http.get("/api/v2/users/:userId/workspace/:workspaceName", async () => {
169+
http.get("/api/v2/users/:userId/workspace/:workspaceName", () => {
176170
return HttpResponse.json(M.MockWorkspace);
177171
}),
178172

179173
// First user
180-
http.get("/api/v2/users/first", async () => {
174+
http.get("/api/v2/users/first", () => {
181175
return new HttpResponse(null, { status: 200 });
182176
}),
183-
http.post("/api/v2/users/first", async () => {
177+
http.post("/api/v2/users/first", () => {
184178
return HttpResponse.json(M.MockUser);
185179
}),
186180

187181
// workspaces
188-
http.get("/api/v2/workspaces", async () => {
182+
http.get("/api/v2/workspaces", () => {
189183
return HttpResponse.json(M.MockWorkspacesResponse);
190184
}),
191-
http.get("/api/v2/workspaces/:workspaceId", async () => {
185+
http.get("/api/v2/workspaces/:workspaceId", () => {
192186
return HttpResponse.json(M.MockWorkspace);
193187
}),
194-
http.put("/api/v2/workspaces/:workspaceId/autostart", async () => {
188+
http.put("/api/v2/workspaces/:workspaceId/autostart", () => {
195189
return new HttpResponse(null, { status: 200 });
196190
}),
197-
http.put("/api/v2/workspaces/:workspaceId/ttl", async () => {
191+
http.put("/api/v2/workspaces/:workspaceId/ttl", () => {
198192
return new HttpResponse(null, { status: 200 });
199193
}),
200-
http.put("/api/v2/workspaces/:workspaceId/extend", async () => {
194+
http.put("/api/v2/workspaces/:workspaceId/extend", () => {
201195
return new HttpResponse(null, { status: 200 });
202196
}),
203-
http.get("/api/v2/workspaces/:workspaceId/resolve-autostart", async () => {
197+
http.get("/api/v2/workspaces/:workspaceId/resolve-autostart", () => {
204198
return HttpResponse.json({ parameter_mismatch: false });
205199
}),
206200

@@ -216,7 +210,7 @@ export const handlers = [
216210
const result = transitionToBuild[transition];
217211
return HttpResponse.json(result);
218212
}),
219-
http.get("/api/v2/workspaces/:workspaceId/builds", async () => {
213+
http.get("/api/v2/workspaces/:workspaceId/builds", () => {
220214
return HttpResponse.json(M.MockBuilds);
221215
}),
222216
http.get("/api/v2/workspaces/:workspaceId/port-share", () => {
@@ -270,7 +264,7 @@ export const handlers = [
270264
return HttpResponse.json([MockGroup]);
271265
}),
272266

273-
http.post("/api/v2/organizations/:organizationId/groups", async () => {
267+
http.post("/api/v2/organizations/:organizationId/groups", () => {
274268
return HttpResponse.json(M.MockGroup, { status: 201 });
275269
}),
276270

0 commit comments

Comments
 (0)