fix: lint errors

brettkolodny · brettkolodny · commit a724f484c93e · 2025-03-06T22:25:00.000Z
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -9584,7 +9584,7 @@ func (q *FakeQuerier) OrganizationMembers(_ context.Context, arg database.Organi
 	return tmp, nil
 }
 
-func (q *FakeQuerier) PaginatedOrganizationMembers(ctx context.Context, arg database.PaginatedOrganizationMembersParams) ([]database.PaginatedOrganizationMembersRow, error) {
+func (q *FakeQuerier) PaginatedOrganizationMembers(_ context.Context, arg database.PaginatedOrganizationMembersParams) ([]database.PaginatedOrganizationMembersRow, error) {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return nil, err
@@ -9602,7 +9602,7 @@ func (q *FakeQuerier) PaginatedOrganizationMembers(ctx context.Context, arg data
 		}
 
 		if skippedMembers < int(arg.OffsetOpt) {
-			skippedMembers += 1
+			skippedMembers++
 			continue
 		}
 
diff --git a/coderd/members.go b/coderd/members.go
@@ -212,7 +212,7 @@ func (api *API) paginatedMembers(rw http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	memberRows := make([]database.OrganizationMembersRow, len(paginatedMemberRows))
+	memberRows := make([]database.OrganizationMembersRow, 0)
 	for _, pRow := range paginatedMemberRows {
 		row := database.OrganizationMembersRow{
 			OrganizationMember: pRow.OrganizationMember,
@@ -227,6 +227,9 @@ func (api *API) paginatedMembers(rw http.ResponseWriter, r *http.Request) {
 	}
 
 	members, err := convertOrganizationMembersWithUserData(ctx, api.Database, memberRows)
+	if err != nil {
+		httpapi.InternalServerError(rw, err)
+	}
 
 	resp := codersdk.PaginatedMembersResponse{
 		Members: members,

Original file line number	Diff line number	Diff line change
`@@ -9584,7 +9584,7 @@ func (q *FakeQuerier) OrganizationMembers(_ context.Context, arg database.Organi`
`9584`	`9584`	`return tmp, nil`
`9585`	`9585`	`}`
`9586`	`9586`
`9587`		`-func (q *FakeQuerier) PaginatedOrganizationMembers(ctx context.Context, arg database.PaginatedOrganizationMembersParams) ([]database.PaginatedOrganizationMembersRow, error) {`
	`9587`	`+func (q *FakeQuerier) PaginatedOrganizationMembers(_ context.Context, arg database.PaginatedOrganizationMembersParams) ([]database.PaginatedOrganizationMembersRow, error) {`
`9588`	`9588`	`err := validateDatabaseType(arg)`
`9589`	`9589`	`if err != nil {`
`9590`	`9590`	`return nil, err`
`@@ -9602,7 +9602,7 @@ func (q *FakeQuerier) PaginatedOrganizationMembers(ctx context.Context, arg data`
`9602`	`9602`	`}`
`9603`	`9603`
`9604`	`9604`	`if skippedMembers < int(arg.OffsetOpt) {`
`9605`		`- skippedMembers += 1`
	`9605`	`+ skippedMembers++`
`9606`	`9606`	`continue`
`9607`	`9607`	`}`
`9608`	`9608`