feat: link with protocol on shared ports

f0ssel · f0ssel · commit a735aacf7e7e · 2024-04-09T16:20:22.000Z
diff --git a/site/src/modules/resources/PortForwardButton.tsx b/site/src/modules/resources/PortForwardButton.tsx
@@ -393,6 +393,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
                   agent.name,
                   workspaceName,
                   username,
+                  share.protocol === "https",
                 );
                 const label = share.port;
                 return (
diff --git a/site/src/utils/portForward.ts b/site/src/utils/portForward.ts
@@ -4,12 +4,13 @@ export const portForwardURL = (
   agentName: string,
   workspaceName: string,
   username: string,
+  https = false,
 ): string => {
   const { location } = window;
+  const suffix = https ? "s" : "";
 
-  const subdomain = `${
-    isNaN(port) ? 3000 : port
-  }--${agentName}--${workspaceName}--${username}`;
+  const subdomain = `${port
+  }${suffix}--${agentName}--${workspaceName}--${username}`;
   return `${location.protocol}//${host}`.replace("*", subdomain);
 };
 
@@ -53,6 +54,7 @@ export const openMaybePortForwardedURL = (
       portForwardURL(
         proxyHost,
         parseInt(url.port),
+
         agentName,
         workspaceName,
         username,
