fix: prevent data race

elasticspoon · elasticspoon · commit a7bc37ea6e11 · 2024-03-21T16:55:30.000-04:00
diff --git a/cli/errors_test.go b/cli/errors_test.go
@@ -24,9 +24,7 @@ type commandErrorCase struct {
 func TestErrorExamples(t *testing.T) {
 	t.Parallel()
 
-	var root cli.RootCmd
-	rootCmd, err := root.Command(root.AGPL())
-	require.NoError(t, err)
+	rootCmd := getRoot(t)
 
 	var cases []commandErrorCase
 
@@ -52,8 +50,7 @@ ExtractCommandPathsLoop:
 
 			var outBuf bytes.Buffer
 
-			rootCmd, err := root.Command(root.AGPL())
-			require.NoError(t, err)
+			rootCmd := getRoot(t)
 
 			inv, _ := clitest.NewWithCommand(t, rootCmd, tt.Cmd...)
 			inv.Stderr = &outBuf
@@ -65,7 +62,7 @@ ExtractCommandPathsLoop:
 				inv.Stdin = os.Stdin
 			}
 
-			err = inv.Run()
+			err := inv.Run()
 
 			errFormatter := cli.ExportNewPrettyErrorFormatter(&outBuf, false)
 			cli.ExportFormat(errFormatter, err)
@@ -84,3 +81,14 @@ func extractCommandPaths(cmdPath []string, cmds []*serpent.Command) [][]string {
 	}
 	return cmdPaths
 }
+
+// Must return a fresh instance of cmds each time.
+func getRoot(t *testing.T) *serpent.Command {
+	t.Helper()
+
+	var root cli.RootCmd
+	rootCmd, err := root.Command(root.AGPL())
+	require.NoError(t, err)
+
+	return rootCmd
+}
