Fix: template name length

mtojek · mtojek · commit a837fae418b8 · 2022-11-10T12:31:54.000+01:00
diff --git a/coderd/httpapi/name.go b/coderd/httpapi/name.go
@@ -57,8 +57,8 @@ func TemplateDisplayNameValid(str string) error {
 	if len(str) == 0 {
 		return nil // empty display_name is correct
 	}
-	if len(str) > 32 {
-		return xerrors.New("must be <= 32 characters")
+	if len(str) > 64 {
+		return xerrors.New("must be <= 64 characters")
 	}
 	matched := templateDisplayName.MatchString(str)
 	if !matched {
diff --git a/coderd/httpapi/name_test.go b/coderd/httpapi/name_test.go
@@ -92,6 +92,9 @@ func TestTemplateDisplayNameValid(t *testing.T) {
 		{"a1b2c3d4e5f6g7h8i9j0k-", true},
 		{"BANANAS_wow", true},
 		{"test--now", true},
+		{"123456789012345678901234567890123", true},
+		{"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", true},
+		{"1234567890123456789012345678901234567890123456789012345678901234", true},
 
 		{" ", false},
 		{" a", false},
@@ -107,10 +110,7 @@ func TestTemplateDisplayNameValid(t *testing.T) {
 		{"-123456789012345678901", false},
 		{"-a1b2c3d4e5f6g7h8i9j0k", false},
 		{"-abcdefghijKLmnopqrstu", false},
-
-		{"123456789012345678901234567890123", false},
-		{"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", false},
-		{"123456789012345678901234567890123123456789012345678901234567890123", false},
+		{"12345678901234567890123456789012345678901234567890123456789012345", false},
 	}
 	for _, testCase := range testCases {
 		testCase := testCase

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,8 @@ func TemplateDisplayNameValid(str string) error {`
`57`	`57`	`if len(str) == 0 {`
`58`	`58`	`return nil // empty display_name is correct`
`59`	`59`	`}`
`60`		`- if len(str) > 32 {`
`61`		`- return xerrors.New("must be <= 32 characters")`
	`60`	`+ if len(str) > 64 {`
	`61`	`+ return xerrors.New("must be <= 64 characters")`
`62`	`62`	`}`
`63`	`63`	`matched := templateDisplayName.MatchString(str)`
`64`	`64`	`if !matched {`