Skip to content

Commit aa1e0d4

Browse files
BrunoQuaresmaBrunoQuaresma
committed
Refactor TemplatesPage tests
1 parent 0e05cd2 commit aa1e0d4

File tree

2 files changed

+74
-161
lines changed

2 files changed

+74
-161
lines changed

‎site/src/pages/TemplatesPage/TemplatesPage.test.tsx

Lines changed: 0 additions & 91 deletions
This file was deleted.

‎site/src/pages/TemplatesPage/TemplatesPageView.stories.tsx

Lines changed: 74 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { ComponentMeta, Story } from "@storybook/react";
21
import {
32
mockApiError,
43
MockOrganization,
@@ -7,92 +6,97 @@ import {
76
MockTemplateExample,
87
MockTemplateExample2,
98
} from "../../testHelpers/entities";
10-
import { TemplatesPageView, TemplatesPageViewProps } from "./TemplatesPageView";
9+
import { TemplatesPageView } from "./TemplatesPageView";
10+
import type { Meta, StoryObj } from "@storybook/react";
1111

12-
export default {
12+
const meta: Meta<typeof TemplatesPageView> = {
1313
title: "pages/TemplatesPageView",
1414
component: TemplatesPageView,
15-
} as ComponentMeta<typeof TemplatesPageView>;
15+
};
1616

17-
const Template: Story<TemplatesPageViewProps> = (args) => (
18-
<TemplatesPageView {...args} />
19-
);
17+
export default meta;
18+
type Story = StoryObj<typeof TemplatesPageView>;
2019

21-
export const WithTemplates = Template.bind({});
22-
WithTemplates.args = {
23-
context: {
24-
organizationId: MockOrganization.id,
25-
permissions: MockPermissions,
26-
error: undefined,
27-
templates: [
28-
MockTemplate,
29-
{
30-
...MockTemplate,
31-
active_user_count: -1,
32-
description: "🚀 Some new template that has no activity data",
33-
icon: "/icon/goland.svg",
34-
},
35-
{
36-
...MockTemplate,
37-
active_user_count: 150,
38-
description: "😮 Wow, this one has a bunch of usage!",
39-
icon: "",
40-
},
41-
{
42-
...MockTemplate,
43-
description:
44-
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. ",
45-
},
46-
],
47-
examples: [],
20+
export const WithTemplates: Story = {
21+
args: {
22+
context: {
23+
organizationId: MockOrganization.id,
24+
permissions: MockPermissions,
25+
error: undefined,
26+
templates: [
27+
MockTemplate,
28+
{
29+
...MockTemplate,
30+
active_user_count: -1,
31+
description: "🚀 Some new template that has no activity data",
32+
icon: "/icon/goland.svg",
33+
},
34+
{
35+
...MockTemplate,
36+
active_user_count: 150,
37+
description: "😮 Wow, this one has a bunch of usage!",
38+
icon: "",
39+
},
40+
{
41+
...MockTemplate,
42+
description:
43+
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. ",
44+
},
45+
],
46+
examples: [],
47+
},
4848
},
4949
};
5050

51-
export const WithTemplatesSmallViewPort = Template.bind({});
52-
WithTemplatesSmallViewPort.args = {
53-
...WithTemplates.args,
54-
};
55-
WithTemplatesSmallViewPort.parameters = {
56-
chromatic: { viewports: [600] },
51+
export const WithTemplatesSmallViewPort: Story = {
52+
args: {
53+
...WithTemplates.args,
54+
},
55+
parameters: {
56+
chromatic: { viewports: [600] },
57+
},
5758
};
5859

59-
export const EmptyCanCreate = Template.bind({});
60-
EmptyCanCreate.args = {
61-
context: {
62-
organizationId: MockOrganization.id,
63-
permissions: MockPermissions,
64-
error: undefined,
65-
templates: [],
66-
examples: [MockTemplateExample, MockTemplateExample2],
60+
export const EmptyCanCreate: Story = {
61+
args: {
62+
context: {
63+
organizationId: MockOrganization.id,
64+
permissions: MockPermissions,
65+
error: undefined,
66+
templates: [],
67+
examples: [MockTemplateExample, MockTemplateExample2],
68+
},
6769
},
6870
};
6971

70-
export const EmptyCannotCreate = Template.bind({});
71-
EmptyCannotCreate.args = {
72-
context: {
73-
organizationId: MockOrganization.id,
74-
permissions: {
75-
...MockPermissions,
76-
createTemplates: false,
72+
export const EmptyCannotCreate: Story = {
73+
args: {
74+
context: {
75+
organizationId: MockOrganization.id,
76+
permissions: {
77+
...MockPermissions,
78+
createTemplates: false,
79+
},
80+
error: undefined,
81+
templates: [],
82+
examples: [MockTemplateExample, MockTemplateExample2],
7783
},
78-
error: undefined,
79-
templates: [],
80-
examples: [MockTemplateExample, MockTemplateExample2],
8184
},
8285
};
8386

84-
export const Error = Template.bind({});
85-
Error.args = {
86-
context: {
87-
organizationId: MockOrganization.id,
88-
permissions: {
89-
...MockPermissions,
90-
createTemplates: false,
87+
export const Error: Story = {
88+
args: {
89+
context: {
90+
organizationId: MockOrganization.id,
91+
permissions: {
92+
...MockPermissions,
93+
createTemplates: false,
94+
},
95+
error: mockApiError({
96+
message: "Something went wrong fetching templates.",
97+
}),
98+
templates: undefined,
99+
examples: undefined,
91100
},
92-
error: mockApiError({
93-
message: "Something went wrong fetching templates.",
94-
}),
95-
templates: undefined,
96-
examples: undefined,
97101
},
98102
};

0 commit comments

Comments
 (0)