ci: Lock PostgreSQL database creation

kylecarbs · kylecarbs · commit aa64d2860c46 · 2022-01-30T01:54:22.000Z
There have been race conditions when multiple instances
are created at once. This is an attempt to fix!
diff --git a/database/postgres/postgres.go b/database/postgres/postgres.go
@@ -5,15 +5,26 @@ import (
 	"fmt"
 	"io/ioutil"
 	"os"
+	"sync"
 	"time"
 
 	"github.com/ory/dockertest/v3"
 	"github.com/ory/dockertest/v3/docker"
 	"golang.org/x/xerrors"
 )
 
+// Locks the creation of a PostgreSQL instance to one-at-a-time.
+// We experienced race conditions when creating multiple instances
+// at a time. Somehow they were sharing data...
+//
+// This may be an upstream issue with "dockertest".
+var createMutex sync.Mutex
+
 // Open creates a new PostgreSQL server using a Docker container.
 func Open() (string, func(), error) {
+	createMutex.Lock()
+	defer createMutex.Unlock()
+
 	pool, err := dockertest.NewPool("")
 	if err != nil {
 		return "", nil, xerrors.Errorf("create pool: %w", err)
