Skip to content

Commit aabb727

Browse files
authored
docs: update CONTRIBUTING requirements (#3541)
* docs: update CONTRIBUTING requirements * Update docs/CONTRIBUTING.md * refactor: remove dev from Makefile * fixup: add linux section
1 parent 55890df commit aabb727

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

Makefile

-5
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ coderd/database/dump.sql: $(wildcard coderd/database/migrations/*.sql)
6363
coderd/database/querier.go: coderd/database/sqlc.yaml coderd/database/dump.sql $(wildcard coderd/database/queries/*.sql)
6464
coderd/database/generate.sh
6565

66-
# This target is deprecated, as GNU make has issues passing signals to subprocesses.
67-
dev:
68-
@echo Please run ./scripts/develop.sh manually.
69-
.PHONY: dev
70-
7166
fmt/prettier:
7267
@echo "--- prettier"
7368
cd site

docs/CONTRIBUTING.md

+10-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,15 @@
22

33
## Requirements
44

5-
Coder requires Go 1.18+, Node 14+, and GNU Make.
5+
You'll need the following tools:
6+
- Go 1.18+
7+
- Node 14+
8+
- GNU Make
9+
- [`shfmt`](https://github.com/mvdan/sh#shfmt)
10+
- [`nfpm`](https://nfpm.goreleaser.com/install)
11+
- [`pg_dump`]
12+
- on macOS, run `brew install libpq zstd`
13+
- on Linux, install [`zstd`](https://github.com/horta/zstd.install)
614

715
> **Note**:
816
> Use [Nix](https://nix.dev/) for a one-command setup: `nix-shell`
@@ -11,7 +19,7 @@ Coder requires Go 1.18+, Node 14+, and GNU Make.
1119

1220
Use the following `make` commands and scripts in development:
1321

14-
- `make dev` runs the frontend and backend development server
22+
- `./scripts/develop.sh` runs the frontend and backend development server
1523
- `make build` compiles binaries and release packages
1624
- `make install` installs binaries to `$GOPATH/bin`
1725
- `make test`

0 commit comments

Comments
 (0)