Fix Garrett's comments

kylecarbs · kylecarbs · commit aad7be440c5e · 2022-09-13T17:37:18.000Z
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -466,7 +466,7 @@ func New(options *Options) *API {
 		})
 		r.Route("/entitlements", func(r chi.Router) {
 			r.Use(apiKeyMiddleware)
-			r.Get("/", entitlements)
+			r.Get("/", nopEntitlements)
 		})
 		r.HandleFunc("/licenses", unsupported)
 	})
@@ -523,7 +523,7 @@ func compressHandler(h http.Handler) http.Handler {
 	return cmp.Handler(h)
 }
 
-func entitlements(rw http.ResponseWriter, _ *http.Request) {
+func nopEntitlements(rw http.ResponseWriter, _ *http.Request) {
 	feats := make(map[string]codersdk.Feature)
 	for _, f := range codersdk.FeatureNames {
 		feats[f] = codersdk.Feature{
diff --git a/enterprise/coderd/coderd.go b/enterprise/coderd/coderd.go
@@ -152,6 +152,8 @@ func (api *API) updateEntitlements(ctx context.Context) error {
 	}
 	if auditLogs != api.auditLogs {
 		auditor := agplaudit.NewNop()
+		// A flag could be added to the options that would allow disabling
+		// enhanced audit logging here!
 		if api.auditLogs == codersdk.EntitlementEntitled {
 			auditor = audit.NewAuditor(
 				audit.DefaultFilter,

Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,8 @@ func (api *API) updateEntitlements(ctx context.Context) error {`
`152`	`152`	`}`
`153`	`153`	`if auditLogs != api.auditLogs {`
`154`	`154`	`auditor := agplaudit.NewNop()`
	`155`	`+ // A flag could be added to the options that would allow disabling`
	`156`	`+ // enhanced audit logging here!`
`155`	`157`	`if api.auditLogs == codersdk.EntitlementEntitled {`
`156`	`158`	`auditor = audit.NewAuditor(`
`157`	`159`	`audit.DefaultFilter,`