add test to ensure workspaces are not autostarted before time

johnstcn · johnstcn · commit abc08543415d · 2022-05-10T20:47:03.000Z
diff --git a/coderd/lifecycle/executor/lifecycle_executor.go b/coderd/lifecycle/executor/lifecycle_executor.go
@@ -109,7 +109,7 @@ func (e *Executor) runOnce(t time.Time) error {
 			)
 
 			if err := doBuild(e.ctx, db, ws, validTransition); err != nil {
-				e.log.Error(e.ctx, "transition workspace",
+				e.log.Error(e.ctx, "unable to transition workspace",
 					slog.F("workspace_id", ws.ID),
 					slog.F("transition", validTransition),
 					slog.Error(err),
diff --git a/coderd/lifecycle/executor/lifecycle_executor_test.go b/coderd/lifecycle/executor/lifecycle_executor_test.go
@@ -2,6 +2,7 @@ package executor_test
 
 import (
 	"context"
+	"fmt"
 	"testing"
 	"time"
 
@@ -274,6 +275,45 @@ func Test_Executor_Workspace_Deleted(t *testing.T) {
 	}, 5*time.Second, 250*time.Millisecond)
 }
 
+func Test_Executor_Workspace_TooEarly(t *testing.T) {
+	t.Parallel()
+
+	var (
+		ctx    = context.Background()
+		err    error
+		tickCh = make(chan time.Time)
+		client = coderdtest.New(t, &coderdtest.Options{
+			LifecycleTicker: tickCh,
+		})
+		// Given: we have a user with a workspace
+		workspace = mustProvisionWorkspace(t, client)
+	)
+
+	// Given: the workspace initially has autostart disabled
+	require.Empty(t, workspace.AutostopSchedule)
+
+	// When: we enable workspace autostart with some time in the future
+	futureTime := time.Now().Add(time.Hour)
+	futureTimeCron := fmt.Sprintf("%d %d * * *", futureTime.Minute(), futureTime.Hour())
+	sched, err := schedule.Weekly(futureTimeCron)
+	require.NoError(t, err)
+	require.NoError(t, client.UpdateWorkspaceAutostop(ctx, workspace.ID, codersdk.UpdateWorkspaceAutostopRequest{
+		Schedule: sched.String(),
+	}))
+
+	// When: the lifecycle executor ticks
+	go func() {
+		tickCh <- time.Now().UTC()
+		close(tickCh)
+	}()
+
+	// Then: nothing should happen
+	require.Never(t, func() bool {
+		ws := mustWorkspace(t, client, workspace.ID)
+		return ws.LatestBuild.Transition != database.WorkspaceTransitionStart
+	}, 5*time.Second, 250*time.Millisecond)
+}
+
 func mustProvisionWorkspace(t *testing.T, client *codersdk.Client) codersdk.Workspace {
 	t.Helper()
 	coderdtest.NewProvisionerDaemon(t, client)

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ func (e *Executor) runOnce(t time.Time) error {`
`109`	`109`	`)`
`110`	`110`
`111`	`111`	`if err := doBuild(e.ctx, db, ws, validTransition); err != nil {`
`112`		`- e.log.Error(e.ctx, "transition workspace",`
	`112`	`+ e.log.Error(e.ctx, "unable to transition workspace",`
`113`	`113`	`slog.F("workspace_id", ws.ID),`
`114`	`114`	`slog.F("transition", validTransition),`
`115`	`115`	`slog.Error(err),`