Skip to content

Commit ad47dc9

Browse files
authored
fix(coderd): set mode and modtime correctly when converting from zip to tar (#12476)
* fix(coderd): set mode and modtime correctly when converting from zip->tar
1 parent 0094b96 commit ad47dc9

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

coderd/fileszip.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,13 @@ func processFileInZipArchive(file *zip.File, tarWriter *tar.Writer) error {
3939
defer fileReader.Close()
4040

4141
err = tarWriter.WriteHeader(&tar.Header{
42-
Name: file.Name,
43-
Size: file.FileInfo().Size(),
44-
Mode: 0o644,
42+
Name: file.Name,
43+
Size: file.FileInfo().Size(),
44+
Mode: int64(file.Mode()),
45+
ModTime: file.Modified,
46+
// Note: Zip archives do not store ownership information.
47+
Uid: 1000,
48+
Gid: 1000,
4549
})
4650
if err != nil {
4751
return err

0 commit comments

Comments
 (0)