fix(agent): start rpty lifecycle after all reads/writes (#15535)

johnstcn · pull[bot] · commit ad7e5182a0f4 · 2024-12-27T18:03:31.000Z
Fixes coder/internal#214 #15475 missed that we also write to `rpty` after starting `rpty.lifecycle()`. This PR moves the function call right at the end. Hopefully this should address the data races before we go resorting to mutexes.
diff --git a/agent/reconnectingpty/screen.go b/agent/reconnectingpty/screen.go
@@ -78,8 +78,6 @@ func newScreen(ctx context.Context, cmd *pty.Cmd, options *Options, logger slog.
 	}
 	rpty.id = hex.EncodeToString(buf)
 
-	go rpty.lifecycle(ctx, logger)
-
 	settings := []string{
 		// Disable the startup message that appears for five seconds.
 		"startup_message off",
@@ -124,6 +122,8 @@ func newScreen(ctx context.Context, cmd *pty.Cmd, options *Options, logger slog.
 		return rpty
 	}
 
+	go rpty.lifecycle(ctx, logger)
+
 	return rpty
 }
 

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,6 @@ func newScreen(ctx context.Context, cmd pty.Cmd, options Options, logger slog.`
`78`	`78`	`}`
`79`	`79`	`rpty.id = hex.EncodeToString(buf)`
`80`	`80`
`81`		`- go rpty.lifecycle(ctx, logger)`
`82`		`-`
`83`	`81`	`settings := []string{`
`84`	`82`	`// Disable the startup message that appears for five seconds.`
`85`	`83`	`"startup_message off",`
`@@ -124,6 +122,8 @@ func newScreen(ctx context.Context, cmd pty.Cmd, options Options, logger slog.`
`124`	`122`	`return rpty`
`125`	`123`	`}`
`126`	`124`
	`125`	`+ go rpty.lifecycle(ctx, logger)`
	`126`	`+`
`127`	`127`	`return rpty`
`128`	`128`	`}`
`129`	`129`