Apply PR comments

BrunoQuaresma · BrunoQuaresma · commit ae753a005a34 · 2025-04-23T14:42:54.000Z
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -396,7 +396,7 @@ export class MissingBuildParameters extends Error {
 }
 
 export type GetProvisionerJobsParams = {
-	status?: TypesGen.ProvisionerJobStatus;
+	status?: string;
 	limit?: number;
 	// IDs separated by comma
 	ids?: string;
@@ -405,7 +405,7 @@ export type GetProvisionerJobsParams = {
 export type GetProvisionerDaemonsParams = {
 	// IDs separated by comma
 	ids?: string;
-	// JSON Object
+	// Stringified JSON Object
 	tags?: string;
 	limit?: number;
 };
diff --git a/site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPage.tsx b/site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPage.tsx
@@ -11,18 +11,18 @@ const OrganizationProvisionerJobsPage: FC = () => {
 	const { organization } = useOrganizationSettings();
 	const [searchParams, setSearchParams] = useSearchParams();
 	const filter = {
-		status: searchParams.get("status") || "",
-		ids: searchParams.get("ids") || "",
+		status: searchParams.get("status") ?? "",
+		ids: searchParams.get("ids") ?? "",
 	};
 	const {
 		data: jobs,
 		isLoadingError,
 		refetch,
 	} = useQuery({
-		...provisionerJobs(organization?.id || "", {
+		...provisionerJobs(organization?.id ?? "", {
 			...filter,
 			limit: 100,
-		} as GetProvisionerJobsParams),
+		}),
 		enabled: organization !== undefined,
 	});
 
diff --git a/site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPageView.tsx b/site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPageView.tsx
@@ -152,7 +152,7 @@ const OrganizationProvisionerJobsPageView: FC<
 						onValueChange={(status) => {
 							onFilterChange({
 								...filter,
-								status: status as ProvisionerJobStatus,
+								status,
 							});
 						}}
 					>
diff --git a/site/src/pages/OrganizationSettingsPage/OrganizationProvisionersPage/OrganizationProvisionersPage.tsx b/site/src/pages/OrganizationSettingsPage/OrganizationProvisionersPage/OrganizationProvisionersPage.tsx
@@ -18,8 +18,8 @@ const OrganizationProvisionersPage: FC = () => {
 	};
 	const [searchParams, setSearchParams] = useSearchParams();
 	const queryParams = {
-		ids: searchParams.get("ids") || "",
-		tags: searchParams.get("tags") || "",
+		ids: searchParams.get("ids") ?? "",
+		tags: searchParams.get("tags") ?? "",
 	};
 	const { organization, organizationPermissions } = useOrganizationSettings();
 	const { entitlements } = useDashboard();

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ const OrganizationProvisionerJobsPageView: FC<`
`152`	`152`	`onValueChange={(status) => {`
`153`	`153`	`onFilterChange({`
`154`	`154`	`...filter,`
`155`		`- status: status as ProvisionerJobStatus,`
	`155`	`+ status,`
`156`	`156`	`});`
`157`	`157`	`}}`
`158`	`158`	`>`