fix IsGithubDotComURL check

hugodutka · hugodutka · commit b08c8c9e1ee8 · 2025-03-20T12:47:29.000Z
diff --git a/coderd/userauth.go b/coderd/userauth.go
@@ -1096,7 +1096,7 @@ func (api *API) userOAuth2Github(rw http.ResponseWriter, r *http.Request) {
 	}
 	// If the user is logging in with github.com we update their associated
 	// GitHub user ID to the new one.
-	if externalauth.IsGithubDotComURL(api.GithubOAuth2Config.AuthCodeURL("")) && user.GithubComUserID.Int64 != ghUser.GetID() {
+	if externalauth.IsGithubDotComURL(api.GithubOAuth2Config.OAuth2Config.AuthCodeURL("")) && user.GithubComUserID.Int64 != ghUser.GetID() {
 		err = api.Database.UpdateUserGithubComUserID(ctx, database.UpdateUserGithubComUserIDParams{
 			ID: user.ID,
 			GithubComUserID: sql.NullInt64{

Original file line number	Diff line number	Diff line change
`@@ -1096,7 +1096,7 @@ func (api API) userOAuth2Github(rw http.ResponseWriter, r http.Request) {`
`1096`	`1096`	`}`
`1097`	`1097`	`// If the user is logging in with github.com we update their associated`
`1098`	`1098`	`// GitHub user ID to the new one.`
`1099`		`- if externalauth.IsGithubDotComURL(api.GithubOAuth2Config.AuthCodeURL("")) && user.GithubComUserID.Int64 != ghUser.GetID() {`
	`1099`	`+ if externalauth.IsGithubDotComURL(api.GithubOAuth2Config.OAuth2Config.AuthCodeURL("")) && user.GithubComUserID.Int64 != ghUser.GetID() {`
`1100`	`1100`	`err = api.Database.UpdateUserGithubComUserID(ctx, database.UpdateUserGithubComUserIDParams{`
`1101`	`1101`	`ID: user.ID,`
`1102`	`1102`	`GithubComUserID: sql.NullInt64{`